rustdoc: fix bump down typing search on Safari#93188
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 24, 2022
Merged
Conversation
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jsha
force-pushed
the
fix-safari-bumpy-search
branch
from
a0a9424 to
97622bd
Compare
camelid
approved these changes
Jan 22, 2022
Member
camelid
left a comment
camelid
left a comment
There was a problem hiding this comment.
Definitely hacky, but at least it's a pretty small hack :)
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 97622bdcc7c7e5bd552eb448ed99c9953566906e has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jan 22, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#90666 (Stabilize arc_new_cyclic) - rust-lang#91122 (impl Not for !) - rust-lang#93068 (Fix spacing for `·` between stability and source) - rust-lang#93103 (Tweak `expr.await` desugaring `Span`) - rust-lang#93113 (Unify search input and buttons size) - rust-lang#93168 (update uclibc instructions for new toolchain, add link from platforms doc) - rust-lang#93185 (rustdoc: Make some `pub` items crate-private) - rust-lang#93196 (Remove dead code from build_helper) Failed merges: - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
|
☔ The latest upstream changes (presumably #93220) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
jsha
force-pushed
the
fix-safari-bumpy-search
branch
from
97622bd to
bc8ef4c
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit bc8ef4c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf) - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)) - rust-lang#93186 (Fix link to CVE-2022-21658) - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar) - rust-lang#93231 (adjust sidebar link brightness) - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar) - rust-lang#93253 (Update theme on pageshow event) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93184.
For some reason, if the search input doesn't have a previous sibling, typing in the search box increases the search-container's size by about 5px on the bottom. Putting in a dummy sibling fixes it.
https://rustdoc.crud.net/jsha/fix-safari-bumpy-search/std/string/struct.String.html
r? @camelid