Merged
Conversation
Currently fails to build:
error[E0600]: cannot apply unary operator `!` to type `!`
--> library/core/tests/ops.rs:239:8
|
239 | if !return () {}
| ^^^^^^^^^^ cannot apply unary operator `!`
They don't need to be `pub`. Making them crate-private improves code clarity and `dead_code` linting.
Stabilize arc_new_cyclic This stabilizes feature `arc_new_cyclic` as the implementation has been merged for one year and there is no unresolved questions. The FCP is not started yet. Closes rust-lang#75861 . ``@rustbot`` label +T-libs-api
impl Not for !
The lack of this impl caused trouble for me in some degenerate cases of macro-generated code of the form `if !$cond {...}`, even without `feature(never_type)` on a stable compiler. Namely if `$cond` contains a `return` or `break` or similar diverging expression, which would otherwise be perfectly legal in boolean position, the code previously failed to compile with:
```console
error[E0600]: cannot apply unary operator `!` to type `!`
--> library/core/tests/ops.rs:239:8
|
239 | if !return () {}
| ^^^^^^^^^^ cannot apply unary operator `!`
```
Fix spacing for `·` between stability and source This puts in an actual space (by adjusting the space-eating operators in our templates), updates the test, and remove the now-unnecessary CSS rule. r? ``@GuillaumeGomez``
Tweak `expr.await` desugaring `Span` Fix rust-lang#93074
Unify search input and buttons size Fixes rust-lang#93060. Here what it looks like:   You can test it [here](https://rustdoc.crud.net/imperio/unify-sizes/std/index.html). r? ``@jsha``
update uclibc instructions for new toolchain, add link from platforms doc 2 quick things: 1) `libc` was updated to make use of features in a uclibc version more recent than the recommended toolchain in the target document, so I updated the link. 2) As has been done with other platforms, link directly from the platform support doc to the target-specific document.
…omez rustdoc: Make some `pub` items crate-private They don't need to be `pub`. Making them crate-private improves code clarity and `dead_code` linting.
…de, r=Mark-Simulacrum Remove dead code from build_helper Tested with `./x.py check` ran on x86_64 Linux.
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
|
📌 Commit 1a935a5 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 1a935a5 with merge f50afa4fa1c8f5c9cf8646493a34bc49efd62698... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
@bors retry spurious test failure armhf-gnu ui/generics/generic-fn-infer.rs |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Jan 23, 2022
Collaborator
|
Finished benchmarking commit (16c1a9d): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
·between stability and source #93068 (Fix spacing for·between stability and source)expr.awaitdesugaringSpan#93103 (Tweakexpr.awaitdesugaringSpan)pubitems crate-private #93185 (rustdoc: Make somepubitems crate-private)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup