Introduce unsafe methods for mutating environment#94619
Closed
jhpratt wants to merge 1 commit intorust-lang:masterfrom
Closed
Introduce unsafe methods for mutating environment#94619jhpratt wants to merge 1 commit intorust-lang:masterfrom
jhpratt wants to merge 1 commit intorust-lang:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
joshtriplett
reviewed
Mar 5, 2022
joshtriplett
reviewed
Mar 5, 2022
joshtriplett
reviewed
Mar 5, 2022
joshtriplett
reviewed
Mar 5, 2022
Member
Author
|
Just pushed up the recommended changes. I think it might be worth holding off on merging this until it's clear whether a "deprecated safe" attribute will work. |
This was referenced Mar 8, 2022
|
I still have to implement it and show it will work, but the |
Member
Author
|
Awesome. I'll leave this open until the initial implementation lands, at which point I think it's safe to assume this won't be accepted. |
Member
Author
|
For the same reason described in #92365, I'm marking this as blocked. @rustbot label -S-waiting-on-review +S-blocked |
Collaborator
|
☔ The latest upstream changes (presumably #93668) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
r? libs |
Contributor
|
Given #124866, I think this can be closed? |
Member
Author
|
Definitely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #92365. I'm not sure if it's worth mentioning platforms by name in the documentation. If we do, it's possible we miss something and lead people to a false sense of security (rather than having them check single-threadedness on every platform).
For sanity purposes I've made all the implementation functions unsafe, regardless of actual safety on that OS. This ensures the API is the same for every platform.
This still needs a tracking issue to be created. Given the discussion in #92365 of a "deprecated safe", I'm not certain whether these functions will ever actually be stabilized.
@rustbot label +T-libs +C-feature-request
r? @joshtriplett