Merged
Conversation
djc
reviewed
Sep 1, 2023
Collaborator
The remaining failure appears to be because
EDIT: Filed an upstream issue about this: BurntSushi/memchr#136 |
complexspaces
requested changes
Sep 2, 2023
The former is not maintained, and produces warnings in GitHub Actions due to node-js deprecations. The latter is used by the other Rustls ecosystems projects and actively maintained.
Previously there was one job that ran clippy across all supported operating systems for both the latest stable, and the MSRV Rust toolchains. This commit splits that job into two: one for stable and one for the MSRV toolchain. This will make it easier to customize MSRV specific settings in a subsequent commit.
This commit adds a variation of the existing `clippy-ci` alias that only tests the `--lib` target. This is intended to be used when linting with the MSRV, where we don't want dev dependencies and other non-essential code being linted with the MSRV toolchain.
Unfortunately Rust 1.64.0 is the oldest toolchain version that we can get working with cargo-ndk, which is required for building *ring* for the Android targets. The prior MSRV was not being tested correctly in CI and so wasn't actually compatible with the crate as it stands today.
With an MSRV of 1.64.0 we can use the latest cargo-ndk release in the v2.12.x stream when doing our MSRV testing for the Android target. The 3.0.x and 3.1.x streams require a more aggressive MSRV than we can support at this time.
Clippy is flagging a couple instances of this:
```
error: unnecessary closure used with `bool::then`
--> src/verification/android.rs:251:18
|
251 | .map(|o| (!o.is_null()).then(|| o))
| ^^^^^^^^^^^^^^^----------
| |
| help: use `then_some(..)` instead: `then_some(o)`
|
```
This commit applies the recommended fix.
This commit adds a cron schedule to the CI workflow so we can catch things like new clippy breakages sooner.
This will allow using the merge queue feature.
cpu
force-pushed
the
cpu-fix-ci-warns_dev
branch
from
b1c46a9 to
8489d3a
Compare
djc
approved these changes
Sep 7, 2023
complexspaces
approved these changes
Sep 7, 2023
Member
Author
|
Thanks for the reviews/input on this work folks. It ended up being hairier than I expected! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch resolves the remaining GitHub warnings from the
actions-rstasks. It also appears that the MSRV related tests weren't working properly in CI, masking some failures that were uncovered with the switch todtolnay/rust-toolchain.I recommend reviewing this commit-by-commit. The top-level highlights:
--libtarget.cargo ndkand transitive deps.Resolves #26