fix: replace color-picker square glyph with a palette icon#287
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Replaces the sidebar window color-picker trigger’s filled-square glyph (U+25A0) with a dedicated line-art PaletteIcon to better convey “color control” and visually match the neighboring PinIcon.
Changes:
- Swap the color-picker trigger content from
■to a new inlinePaletteIconSVG. - Add a new
PaletteIconcomponent (13×13,strokeWidth={2}, filled paint blobs) witharia-hiddenfor decorative use.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The window color-picker trigger in the sidebar rendered a
U+25A0filled square (■) — the same glyph the media world uses for "stop," so it read as an action button rather than a color control. This replaces it with a hand-rolledPaletteIcon(an artist's palette with four paint blobs), matching the neighboringPinIcon's line-art style.PaletteIconcomponent inwindow-row.tsx, swapped in for the■glyph on the color-picker button. Thearia-label("Set color for …") and all opacity/hover/coarse:/focus-visible:classes are unchanged, so behavior, keyboard focus, and touch reveal are identical.strokeWidthis set to2(not the lucide default1.7) so the icon's effective stroke weight (~1.08px at 13px) matches the pin (~1.125px) — a thinner stroke reads as a lighter color even with the samecurrentColortoken, so weight parity is what makes the cluster look uniform.stroke="none"pure fills so they read as dots, not stroked rings.Verified:
just check(tsc) clean;window-row.test.tsx30/30 and full frontend unit suite 794/794 pass. Frontend-only, presentational change — no Go or API surface touched.