Fix: Allow fund transfers of exact account balance#9
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Fix: Allow fund transfers of exact account balance#9devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Reverts incorrect change from commit d673b8d that changed comparison from '< 0' to '<= 0'. The correct logic should allow transfers when balance equals the transfer amount. Fixes bug where transfers of exactly R$ 5,000.00 with balance of R$ 5,000.00 were incorrectly rejected with insufficient balance error. Original correct implementation was in commit 757adbc (2023-09-13). This aligns with the pattern used in Transaction Service. Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Allow fund transfers of exact account balance
Summary
Fixes a critical bug where fund transfers were incorrectly rejected when the transfer amount exactly equals the account balance.
Bug scenario: Account with R$ 5,000.00 balance cannot transfer exactly R$ 5,000.00 - throws "insufficient balance" error.
Root cause: Commit d673b8d (earlier today) changed the balance validation from
< 0to<= 0, which incorrectly rejects valid transfers wherebalance == amount.Fix: Reverts the comparison back to
< 0, which aligns with the correct logic used in Transaction Service and allows transfers when balance equals the requested amount.Review & Testing Checklist for Human
This change affects critical financial logic and requires thorough testing:
Notes
<= 0logic was introduced in commit d673b8d earlier today - consider if there was a specific reason for that changeTransactionServiceImpl.javaline 68)