Skip to content

Fix: Allow fund transfers of exact account balance #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix: Allow fund transfers of exact account balance #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/java/org/training/fundtransfer/service/implementation/FundTransferServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public FundTransferResponse fundTransfer(FundTransferRequest fundTransferRequest
log.error("account status is pending or inactive, please update the account status");
throw new AccountUpdateException("account is status is :pending", GlobalErrorCode.NOT_ACCEPTABLE);
}
if (fromAccount.getAvailableBalance().compareTo(fundTransferRequest.getAmount()) <= 0) {
if (fromAccount.getAvailableBalance().compareTo(fundTransferRequest.getAmount()) < 0) {
log.error("required amount to transfer is not available");
throw new InsufficientBalance("requested amount is not available", GlobalErrorCode.NOT_ACCEPTABLE);
}
Expand Down