feat: custom in-memory indexes#2379
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2379 +/- ##
==========================================
+ Coverage 85.57% 85.60% +0.02%
==========================================
Files 49 49
Lines 7669 7671 +2
==========================================
+ Hits 6563 6567 +4
+ Misses 1106 1104 -2
|
|
Just looking for preliminary thoughts here @flying-sheep |
…into ig/custom_index_objects
…into ig/custom_index_objects
This is still an outstanding question to me but on second thought, nothing seems to have actually changed. This was always allowed before, but maybe this PR should disallow it if the restriction setting is on? There's a warning about this but that's it. So maybe a test would be good UPDATE: Ok I thought of that and https://github.com/scverse/anndata/pull/2379/changes#diff-93807bfddb872b9cf4ea7586b7ee8feb73bb9cab28969a82b4b6974001ff3462R749-R753 is what we do i.e., leave the old mechanism in place, which is probably the least disruptive thing to do |
Co-authored-by: Philipp A. <flying-sheep@web.de>
From the proteomics hackathon, we definitely need to define some parameters and work out kinks:
AnnData.unwriteablebased onAnnData._reduce+iter_outer+ refactorings of other relevant functions #2372 + Lenient write #2373 + Handle new zarr dtypes (both custom and datetime) #2238. Conretely, feat:AnnData.unwriteablebased onAnnData._reduce+iter_outer+ refactorings of other relevant functions #2372 needs to go in first to prevent people from even trying to write these i.e., when there is aMultiIndexadata.obs_names = non_string_indexand this evidently worked? This will be essential for documentation