Conversation
3 tasks
steiler
added
the
paired-test
Implement the sensitive-data PRD: key-pruned path markers unioned across intents for merged views, RenderOpts-driven `***` redaction in JSON/XML/proto/ XPath output, BlameConfig and deviation masking, admin bypass via include_sensitive, and atomic TransactionSet persistence of sensitive_paths with a datastore reverse index for O(1) lookup. Co-authored-by: Cursor <cursoragent@cursor.com>
…sions Replaces the local-path replace directives with remote pseudo-version references so CI and collaborators can build without local checkouts. Pinned commits: - sdcio/goyang v1.6.2-2.0.20260608121857-4668a077cf72 (PR#4) - sdcio/sdc-protos v0.0.55-0.20260610090020-aeb8edf494c4 (PR#123) Replace with tagged releases once PRs are merged. Co-authored-by: Cursor <cursoragent@cursor.com>
Makes the PR description link to docs/prd/sensitive-data/PRD.md valid on the branch; tracks implementation issues 01–05 for reviewers. Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit 70a7374.
Apply De Morgan's law in json/xml presence-container checks and remove unused setupLeafMock test helper. Co-authored-by: Cursor <cursoragent@cursor.com>
populateSensitivePathIndex streams intents at datastore startup; without the mock the test helper blocked forever waiting on unclosed channels. Co-authored-by: Cursor <cursoragent@cursor.com>
The ToXML signature was refactored in the sensitive-redaction commit to
accept XMLRenderOpts instead of individual bool parameters. One test call
at line 768 was missed during the rebase and still used the old positional
args — replace it with an empty XMLRenderOpts{} (all false, same effect).
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #452 — head branch renamed from
feat/sensitive-data-northboundtosensitiveto pair with the matchingsensitivebranch on config-server (forpaired-testCI integration).Summary
Implements sensitive-data northbound redaction: operators can mark key-pruned schema paths as sensitive on intent write; northbound responses redact matching leaves to
***while southbound apply stays unchanged. Merged views (GetIntent(running),BlameConfig, deviation streaming) use the union of all non-running intents’ markers so priority changes cannot expose secrets; single-intentGetIntentuses only that intent’s markers.include_sensitiveonGetIntentRequest/BlameConfigRequestis threaded through as the admin bypass hook in the render pipeline.Datastore maintains a reverse index for sensitive-path unions;
TransactionSetpersistssensitive_pathsatomically with the intent blob. Tree render ops useRenderOpts/XMLRenderOpts/XPathRenderOpts; blame and deviation paths mask values consistently with render.Dependencies
go.modpins pre-merge commits so CI can build without local checkouts (replace with tagged releases after merge):github.com/sdcio/goyangv1.6.2-2.0.20260608121857-4668a077cf72github.com/sdcio/sdc-protosv0.0.55-0.20260610090020-aeb8edf494c4Related: schema-server#244 (schema
Sensitiveflag from YANG).Test plan
go test ./...GetIntent/BlameConfigwith and withoutinclude_sensitivePairs-with: sdcio/integration-tests#108
Pairs-with: sdcio/config-server#441