Narrow optional import exception handling in pyisolate.__init__#197
Merged
seanwevans merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cryptographydependency is absent.Description
except Exceptionaroundfrom .checkpoint import checkpoint, restoreandfrom .migration import migratewithexcept (ModuleNotFoundError, ImportError)and inspect the exception before deciding to swallow it.ModuleNotFoundError/ImportErrorinstances that do not indicate thecryptographydependency is missing so unexpected import-time failures propagate.checkpoint,restore, andmigratethat raiseModuleNotFoundError("cryptography is required ...")to keep the same API shape and messages.Testing
python -m compileall pyisolate/__init__.pywhich completed successfully.Codex Task