Skip to content

Narrow optional import exception handling in pyisolate.__init__ #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanwevans merged 1 commit into from
Apr 21, 2026
Merged

Narrow optional import exception handling in pyisolate.__init__ #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions pyisolate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,17 @@

try:
from .checkpoint import checkpoint, restore
except Exception: # pragma: no cover - optional dependency
except (ModuleNotFoundError, ImportError) as exc: # pragma: no cover - optional dependency
# Trap only dependency-related import failures; let unrelated import-time
# bugs in optional modules propagate so they remain visible to developers.
if (
isinstance(exc, ModuleNotFoundError)
and exc.name
and exc.name.split(".", 1)[0] != "cryptography"
):
raise
if isinstance(exc, ImportError) and "cryptography" not in str(exc):
raise

def checkpoint(*args, **kwargs): # type: ignore[no-redef]
raise ModuleNotFoundError("cryptography is required for checkpoint support")
Expand Down Expand Up @@ -48,7 +58,17 @@ def restore(*args, **kwargs): # type: ignore[no-redef]

try:
from .migration import migrate
except Exception: # pragma: no cover - optional dependency
except (ModuleNotFoundError, ImportError) as exc: # pragma: no cover - optional dependency
# Trap only dependency-related import failures; let unrelated import-time
# bugs in optional modules propagate so they remain visible to developers.
if (
isinstance(exc, ModuleNotFoundError)
and exc.name
and exc.name.split(".", 1)[0] != "cryptography"
):
raise
if isinstance(exc, ImportError) and "cryptography" not in str(exc):
raise

def migrate(*args, **kwargs): # type: ignore[no-redef]
raise ModuleNotFoundError("cryptography is required for migration support")
Expand Down
Loading