Fix pin operator incorrectly applied to variables in pattern match body#59
Closed
ofedoren wants to merge 1 commit into
Closed
Fix pin operator incorrectly applied to variables in pattern match body#59ofedoren wants to merge 1 commit into
ofedoren wants to merge 1 commit into
Conversation
Bug: process_in processes both the pattern and the body while the
SexpProcessor context stack contains :in. The __var method checks
context[1] for :in or /_pat$/ and prepends ^ (pin operator) to all
lvar references. This causes local variables in the body (after "then")
to be incorrectly rendered with ^, producing invalid Ruby.
For example, `case x; in [a, b]; a; end` was rendered as:
case x
in [a, b] then
^a # <-- wrong: ^ should only appear in patterns
end
Fix: wrap body processing in `in_context :in_body` so that __var sees
:in_body instead of :in on the context stack and skips the pin prefix.
Pattern variables inside the pattern itself continue to be pinned
correctly since the pattern is still processed in :in context.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Good find! Done... this will be released soonish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: process_in processes both the pattern and the body while the SexpProcessor context stack contains :in. The __var method checks context[1] for :in or /_pat$/ and prepends ^ (pin operator) to all lvar references. This causes local variables in the body (after "then") to be incorrectly rendered with ^, producing invalid Ruby.
For example,
case x; in [a, b]; a; endwas rendered as:Fix: wrap body processing in
in_context :in_bodyso that __var sees :in_body instead of :in on the context stack and skips the pin prefix. Pattern variables inside the pattern itself continue to be pinned correctly since the pattern is still processed in :in context.Found during theforeman/safemode#60. Seemed good enough to make a patch suggestion here, so please tell what do you think :)