Skip to content

Fix pin operator incorrectly applied to variables in pattern match body #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ofedoren wants to merge 1 commit into from
+15 −1
Closed

Fix pin operator incorrectly applied to variables in pattern match body #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/ruby2ruby.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,11 @@ def process_in exp # :nodoc:
_, lhs, *rhs = exp

cond = process lhs
body = rhs.compact.map { |sexp| indent process sexp }
body = rhs.compact.map { |sexp|
in_context :in_body do
indent process sexp
end
}

body << indent("# do nothing") if body.empty?
body = body.join "\n"
Expand Down
10 changes: 10 additions & 0 deletions test/test_ruby2ruby.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,16 @@ def test_case_in__hash_pat_14
assert_case_in "Object[b: 1]", s(:hash_pat, s(:const, :Object), s(:lit, :b), s(:lit, 1))
end

def test_case_in_body_does_not_pin_variables
inn = s(:case, s(:call, nil, :x),
s(:in,
s(:array_pat, nil, s(:lasgn, :a), s(:lasgn, :b)),
s(:lvar, :a)),
nil)
out = "case x\nin [a, b] then\n a\nend"
assert_parse inn, out
end

def test_interpolation_and_escapes
# log_entry = " \e[#{message_color}m#{message}\e[0m "
inn = s(:lasgn, :log_entry,
Expand Down