test: Yiren/fkv mig int rebase v2#3503
Conversation
PR SummaryHigh Risk Overview State-commit / migration behavior changes include configurable Reviewed by Cursor Bugbot for commit 6b88c30. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
- Coverage 59.11% 59.08% -0.04%
==========================================
Files 2187 2188 +1
Lines 182236 182393 +157
==========================================
+ Hits 107724 107761 +37
- Misses 64864 64981 +117
- Partials 9648 9651 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1269124cba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if n := cast.ToInt(v); n > 0 { | ||
| scConfig.KeysToMigratePerBlock = n |
There was a problem hiding this comment.
Reject invalid sc-keys-to-migrate-per-block values
When state-commit.sc-keys-to-migrate-per-block is present but non-positive (or non-numeric, which cast.ToInt turns into 0), this code silently ignores the user-provided value and keeps the default 1024 instead of surfacing a config error. That makes bad configs look successful and can materially change migration behavior (for example, operators/tests expecting a tiny batch size will actually run at 1024 keys/block). Since StateCommitConfig.Validate() already defines <= 0 as invalid, swallowing the value here bypasses that validation signal and hides misconfiguration.
Useful? React with 👍 / 👎.
1269124 to
d426f57
Compare
d426f57 to
6b88c30
Compare
Describe your changes and provide context
Testing performed to validate your change