-
Notifications
You must be signed in to change notification settings - Fork 879
test: Yiren/fkv mig int rebase v2 #3503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blindchaser
wants to merge
20
commits into
main
Choose a base branch
from
yiren/fkv-mig-int-rebase-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1aa0d1e
flatkv migration testings
blindchaser 59f1792
fix upgrade module
blindchaser 0a54dcd
fix migration manager iterator
blindchaser b8419ec
fix SetInitialVersion
blindchaser ea866a1
fix flatkv evm migration progress in live blocks
blindchaser 747f9f2
more logs
blindchaser f2f5f3e
add more metrics for testing
blindchaser 4200019
t
blindchaser f96079d
address bug
blindchaser c58f1e7
more keys
blindchaser 50fc1d0
fix
blindchaser 7a8dfbd
try simplify
blindchaser 5156092
renaming
blindchaser 292c1e8
address comment
blindchaser 8cdb57d
address metrics location
blindchaser ec3b449
fix local metrics close()
blindchaser 46f3d10
gate empty-changeset forwarding to one per commit cycle
blindchaser b7bce28
Merge branch 'main' into yiren/fkv-mig-int-rebase
blindchaser 134e164
Merge branch 'main' into yiren/fkv-mig-int-rebase
blindchaser 6b88c30
more migration testings
blindchaser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
state-commit.sc-keys-to-migrate-per-blockis present but non-positive (or non-numeric, whichcast.ToIntturns into0), this code silently ignores the user-provided value and keeps the default1024instead of surfacing a config error. That makes bad configs look successful and can materially change migration behavior (for example, operators/tests expecting a tiny batch size will actually run at 1024 keys/block). SinceStateCommitConfig.Validate()already defines<= 0as invalid, swallowing the value here bypasses that validation signal and hides misconfiguration.Useful? React with 👍 / 👎.