Handle missing nonce on RFC 3161 timestamp#305
Open
haines wants to merge 2 commits into
Open
Conversation
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
Author
|
@Hayden-IO could you please take a look? |
Hayden-IO
previously approved these changes
May 19, 2026
Contributor
Hayden-IO
left a comment
There was a problem hiding this comment.
Looks correct to me, added a sigstore-ruby maintainer to take a look
segiddins
previously approved these changes
May 23, 2026
Member
|
I dont know why I'm not able to kick off the GHA workflows... additionally, it would be awesome if you were able to add a test that covers this |
Author
|
@segiddins I've added a test that fails without this change, using the signed timestamp from #304. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #304
RFC 3161 timestamps have an optional nonce, but verification fails if this is absent.
This PR prevents the error by guarding the assignment of
noncein theOpenSSL::Timestamp::Requestwith a check that it isn'tnil.Release Note
Fix verification of RFC 3161 timestamps without nonces.
Documentation
No