Skip to content

Handle missing nonce on RFC 3161 timestamp #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haines wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle missing nonce on RFC 3161 timestamp #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698d350
Handle missing nonce on RFC 3161 timestamp
haines Mar 30, 2026
9ccacd4
Add test
haines May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sigstore/verifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ def extract_timestamp_from_verification_data(data)
req.message_imprint = resp.token_info.message_imprint
req.algorithm = resp.token_info.algorithm
req.policy_id = resp.token_info.policy_id
req.nonce = resp.token_info.nonce
req.nonce = resp.token_info.nonce unless resp.token_info.nonce.nil?
req.version = resp.token_info.version

# TODO: verify the hashed message in the message imprint
Expand Down
14 changes: 14 additions & 0 deletions test/sigstore/verifier_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,18 @@ def test_pack_digitally_signed_precertificate
].map!(&:b).join, data, "precert_bytes_len=#{precert_bytes_len}"
end
end

def test_extract_timestamp_from_verification_data_without_rfc_3161_nonce
verifier = Sigstore::Verifier.production

timestamp = Sigstore::Common::V1::RFC3161SignedTimestamp.new
timestamp.signed_timestamp = Base64.decode64(<<~BASE64)
MIICyTADAgEAMIICwAYJKoZIhvcNAQcCoIICsTCCAq0CAQMxDTALBglghkgBZQMEAgEwgbgGCyqGSIb3DQEJEAEEoIGoBIGlMIGiAgEBBgkrBgEEAYO/MAIwMTANBglghkgBZQMEAgEFAAQgTKqbxePJ+CMrGBHbCJdNl3teazpMNV33uU8kNYjy92ICFQDHJBQaFf/zj3wr29ngtGyA4ySWVhgPMjAyNjAzMjgwMDA5NTlaMAMCAQGgMqQwMC4xFTATBgNVBAoTDHNpZ3N0b3JlLmRldjEVMBMGA1UEAxMMc2lnc3RvcmUtdHNhoAAxggHaMIIB1gIBATBRMDkxFTATBgNVBAoTDHNpZ3N0b3JlLmRldjEgMB4GA1UEAxMXc2lnc3RvcmUtdHNhLXNlbGZzaWduZWQCFDoTVC8MkGHuvMFDL8uKjosqI4sMMAsGCWCGSAFlAwQCAaCB/DAaBgkqhkiG9w0BCQMxDQYLKoZIhvcNAQkQAQQwHAYJKoZIhvcNAQkFMQ8XDTI2MDMyODAwMDk1OVowLwYJKoZIhvcNAQkEMSIEIHd3A50sJJyWXPJleY3p7eklwNNBmjXWyHwpZT31UrMbMIGOBgsqhkiG9w0BCRACLzF/MH0wezB5BCCF+Se8B6tiysO0Q1bBDvyBssaIP9p6uebYcNnROs0FtzBVMD2kOzA5MRUwEwYDVQQKEwxzaWdzdG9yZS5kZXYxIDAeBgNVBAMTF3NpZ3N0b3JlLXRzYS1zZWxmc2lnbmVkAhQ6E1QvDJBh7rzBQy/Lio6LKiOLDDAKBggqhkjOPQQDAgRmMGQCMHpk9rghxIn1pe2SglUQbCIWgbQKvPOoNzUQrEeAlH3jhFvZDV9PVGQ58uBt5qnszgIwL4seQSRmpcehSGi/yN4mearqVqhTewXDzdvP579e/rM9b93w1rAA2q1UYfCM3Bq2
BASE64

data = Sigstore::Bundle::V1::TimestampVerificationData.new
data.rfc3161_timestamps = [timestamp]

assert_equal verifier.send(:extract_timestamp_from_verification_data, data), [Time.parse("2026-03-28T00:09:59Z")]
end
end
Loading