Keep assignee on onboarding requests even after resolving

[Nateowami]

Previously resolving an onboarding request cleared the assignee. It was requested that the assignee stay on the request, so it's possible to look back at requests and see who handled them.

This necessitated two changes:

1. Stop clearing the assignee when the request is resolved
2. Update the status calculation to not assume that a request that has an assignee is in progress.

---

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (8182c42) to head (4bc29b7).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...c/SIL.XForge.Scripture/Models/OnboardingRequest.cs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         619      619           
  Lines       38619    38618    -1     
  Branches     6317     6317           
=======================================
  Hits        31601    31601           
- Misses       6044     6056   +12     
+ Partials      974      961   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

Just one nit!

@pmachapman reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).

---

src/SIL.XForge.Scripture/Models/OnboardingRequest.cs line 45 at r1 (raw file):

        {
            bool hasAssignee = !String.IsNullOrEmpty(AssigneeId);
            bool isResolved = !String.IsNullOrEmpty(Resolution) && Resolution != "unresolved";

Nit: In C# we normally use lowercase string, i.e.

             bool hasAssignee = !string.IsNullOrEmpty(AssigneeId);
            bool isResolved = !string.IsNullOrEmpty(Resolution) && Resolution != "unresolved";

I am surprised your dev environment didn't give you the "IDE0049 Name can be simplified" warning?

Code quote:

            bool hasAssignee = !String.IsNullOrEmpty(AssigneeId);
            bool isResolved = !String.IsNullOrEmpty(Resolution) && Resolution != "unresolved";

[pmachapman]

@pmachapman reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

[Nateowami]

@Nateowami made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved.

---

src/SIL.XForge.Scripture/Models/OnboardingRequest.cs line 45 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Nit: In C# we normally use lowercase string, i.e.

             bool hasAssignee = !string.IsNullOrEmpty(AssigneeId);
            bool isResolved = !string.IsNullOrEmpty(Resolution) && Resolution != "unresolved";

I am surprised your dev environment didn't give you the "IDE0049 Name can be simplified" warning?

Thanks for the review. Fixed.

My editor does show this, but not as a warning.

I interpreted it as "You could completely drop String here and write IsNullOrEmpty(AssigneeId), which I wasn't sure I wanted to do, since I generally prefer to err on the side of over-qualifying names.