Skip to content

Bugfix: Corrected the conversion of nanoseconds to milliseconds in DateComponents#101

Merged
marcprux merged 1 commit intoskiptools:mainfrom
fhasse95:Create-Calendar-Components-Nanosecond-Bugfix
Mar 12, 2026
Merged

Bugfix: Corrected the conversion of nanoseconds to milliseconds in DateComponents#101
marcprux merged 1 commit intoskiptools:mainfrom
fhasse95:Create-Calendar-Components-Nanosecond-Bugfix

Conversation

@fhasse95
Copy link
Contributor

This PR corrects the conversion of nanoseconds to milliseconds within the DateComponents class.


Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@cla-bot cla-bot bot added the cla-signed label Mar 12, 2026
@marcprux marcprux merged commit 50108e8 into skiptools:main Mar 12, 2026
1 of 2 checks passed
@marcprux
Copy link
Member

Thanks. Do you need a new skip-foundation release with this in it?

@fhasse95
Copy link
Contributor Author

Thanks. Do you need a new skip-foundation release with this in it?

Yes, that would be great :)

@fhasse95 fhasse95 deleted the Create-Calendar-Components-Nanosecond-Bugfix branch March 12, 2026 21:45
@marcprux
Copy link
Member

I released 1.3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants