Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for the Testing library in a transpiled Skip Lite module. Some macros like
#expectand#requireare transpiled into the equivalent JUnit testing calls, andimport Testingis processed in the same way asimport XCTest.In addition, a Skip module can elide the
XCSkipTests.swifttest case and it will be automatically generated by the skipstone plugin if it is seen to be missing. The defaultskip initandskip createprojects will no longer create aXCSkipTests.swiftfile and will instead rely on the auto-generated version.Addresses (but does not completely fix) skiptools/skip#513