add beholder metrics for RPC call counts#365
Merged
poopoothegorilla merged 1 commit intodevelopfrom Feb 20, 2026
Merged
Conversation
Contributor
|
👋 poopoothegorilla, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
✅ API Diff Results - No breaking changes |
dhaidashenko
approved these changes
Feb 19, 2026
Unheilbar
approved these changes
Feb 19, 2026
jmank88
approved these changes
Feb 20, 2026
Comment on lines
+19
to
+20
| func newRPCClientMetrics() (*rpcClientMetrics, error) { | ||
| callsTotal, err := beholder.GetMeter().Int64Counter("evm_pool_rpc_node_calls_total") |
Collaborator
There was a problem hiding this comment.
Nit/ if you inject this then it keeps things decoupled and testable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/txmgr/metrics.go.chainFamily,chainID,nodeName,rpcDomain,callName.Resolves PLEX-2536
Changes
pkg/client/metrics.go—rpcClientMetricsstruct with beholder Int64Counters and increment methodspkg/client/rpc_client.go— addedbeholderMetricsfield toRPCClient, initialized in constructor; addedctxparam tologResultand updated all 27 call sitespkg/client/metrics_test.go— tests for counter creation and incrementTest plan
TestNewRPCClientMetrics,TestRPCClientMetrics_Increment)