Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions pkg/client/metrics.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
package client

import (
"context"
"fmt"

"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/metric"

"github.com/smartcontractkit/chainlink-common/pkg/beholder"
)

type rpcClientMetrics struct {
callsTotal metric.Int64Counter
callsSuccess metric.Int64Counter
callsFailed metric.Int64Counter
}

func newRPCClientMetrics() (*rpcClientMetrics, error) {
callsTotal, err := beholder.GetMeter().Int64Counter("evm_pool_rpc_node_calls_total")
Comment on lines +19 to +20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit/ if you inject this then it keeps things decoupled and testable

if err != nil {
return nil, fmt.Errorf("failed to register rpc calls total metric: %w", err)
}

callsSuccess, err := beholder.GetMeter().Int64Counter("evm_pool_rpc_node_calls_success")
if err != nil {
return nil, fmt.Errorf("failed to register rpc calls success metric: %w", err)
}

callsFailed, err := beholder.GetMeter().Int64Counter("evm_pool_rpc_node_calls_failed")
if err != nil {
return nil, fmt.Errorf("failed to register rpc calls failed metric: %w", err)
}

return &rpcClientMetrics{
callsTotal: callsTotal,
callsSuccess: callsSuccess,
callsFailed: callsFailed,
}, nil
}

func (m *rpcClientMetrics) IncrementTotal(ctx context.Context, chainID, nodeName, rpcDomain, callName string) {
m.callsTotal.Add(ctx, 1, metric.WithAttributes(
attribute.String("chainFamily", "EVM"),
attribute.String("chainID", chainID),
attribute.String("nodeName", nodeName),
attribute.String("rpcDomain", rpcDomain),
attribute.String("callName", callName),
))
}

func (m *rpcClientMetrics) IncrementSuccess(ctx context.Context, chainID, nodeName, rpcDomain, callName string) {
m.callsSuccess.Add(ctx, 1, metric.WithAttributes(
attribute.String("chainFamily", "EVM"),
attribute.String("chainID", chainID),
attribute.String("nodeName", nodeName),
attribute.String("rpcDomain", rpcDomain),
attribute.String("callName", callName),
))
}

func (m *rpcClientMetrics) IncrementFailed(ctx context.Context, chainID, nodeName, rpcDomain, callName string) {
m.callsFailed.Add(ctx, 1, metric.WithAttributes(
attribute.String("chainFamily", "EVM"),
attribute.String("chainID", chainID),
attribute.String("nodeName", nodeName),
attribute.String("rpcDomain", rpcDomain),
attribute.String("callName", callName),
))
}
35 changes: 35 additions & 0 deletions pkg/client/metrics_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package client

import (
"context"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestNewRPCClientMetrics(t *testing.T) {
m, err := newRPCClientMetrics()
require.NoError(t, err)
require.NotNil(t, m)
assert.NotNil(t, m.callsTotal)
assert.NotNil(t, m.callsSuccess)
assert.NotNil(t, m.callsFailed)
}

func TestRPCClientMetrics_Increment(t *testing.T) {
m, err := newRPCClientMetrics()
require.NoError(t, err)

ctx := context.Background()

assert.NotPanics(t, func() {
m.IncrementTotal(ctx, "1", "node-1", "rpc.example.com", "eth_call")
})
assert.NotPanics(t, func() {
m.IncrementSuccess(ctx, "1", "node-1", "rpc.example.com", "eth_call")
})
assert.NotPanics(t, func() {
m.IncrementFailed(ctx, "1", "node-1", "rpc.example.com", "eth_call")
})
}
Loading
Loading