chore: fix transitive dependencies being marked as directly upgradable#582
Open
CatalinSnyk wants to merge 2 commits intomainfrom
Open
chore: fix transitive dependencies being marked as directly upgradable#582CatalinSnyk wants to merge 2 commits intomainfrom
CatalinSnyk wants to merge 2 commits intomainfrom
Conversation
…pgradable in the remediation summary
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
7675487 to
91c0e0c
Compare
CatalinSnyk
commented
Apr 9, 2026
| matchedPaths++ | ||
| fromPkg := depPath[1] | ||
| toPkg := upgradePath.DependencyPath[1] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is the main fix to ensure transitive dependency upgrades are not reported as directly upgradable.
PR Reviewer Guide 🔍
|
CatalinSnyk
commented
Apr 9, 2026
| } | ||
|
|
||
| // Filter out unresolved issues that are already covered by a pin. | ||
| summary.Unresolved = filterUnresolvedCoveredByPins(summary.Unresolved, summary.Pins) |
Contributor
Author
There was a problem hiding this comment.
Added this to match the logic in the legacy implementation. I didn't add another fixture file in this PR, but I left an action items for adding a Python project one in CLI-1349, and settled for just a unit test case for now.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In certain cases the Remediation Summary would count transitive dependency upgrades as directly upgradable. This would results in incorrect upgrade advice (e.g.
Upgrade from x@1.2.3 to x@1.2.3- since the actual upgrade would be inside for a nested dependency).The changes should allign the remediation summary building with the legacy implementation that can be found here. In terms of tests, I added a few more cases to the remedation testing logic to get the coverage to 85%, but I also slightly updated the
testresults_cli.jsonto the newer TestAPI structure in order to add it as a test case for the human readable output.Checklist
make test)make generate)make lint)