added scripts, updated contributing.md, fixed install issues#20
Open
tshmieldev wants to merge 1 commit intomainfrom
Open
added scripts, updated contributing.md, fixed install issues#20tshmieldev wants to merge 1 commit intomainfrom
tshmieldev wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a root-level developer workflow for installing JS/TS dependencies and running linters across the monorepo, while updating ESLint configs to enforce unused import cleanup and documenting the new setup in CONTRIBUTING.
Changes:
- Added root
package.jsonscripts andscripts/*.shhelpers forinstall:alland multi-language linting. - Updated ESLint configs in
PulsarAppandreact-native-pulsarto useeslint-plugin-unused-imports. - Updated
CONTRIBUTING.mdto direct contributors to the root install/lint workflow; lockfiles updated accordingly.
Reviewed changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/lint.sh | Aggregates JS/TS, Kotlin, and Swift lint scripts into one command. |
| scripts/lint-js.sh | Runs ESLint in PulsarApp and the RN library via npm --prefix. |
| scripts/lint-kotlin.sh | Adds ktlint invocation for Android and RN-Android Kotlin sources. |
| scripts/lint-swift.sh | Adds swiftlint invocation for iOS SDK and RN-iOS sources. |
| scripts/install.sh | Installs dependencies in RN lib, PulsarApp, and docs from repo root. |
| package.json | Introduces root “orchestrator” scripts (install:all, lint:*). |
| react-native/react-native-pulsar/package.json | Adds eslint-plugin-unused-imports (dev dependency). |
| react-native/react-native-pulsar/package-lock.json | Lockfile updated for new dev dependency and version metadata. |
| react-native/react-native-pulsar/eslint.config.mjs | Configures unused-imports plugin and rules; disables base unused-vars rules. |
| react-native/react-native-pulsar/.npmrc | Adds legacy-peer-deps=true to change npm install behavior. |
| PulsarApp/package.json | Adds eslint-plugin-unused-imports (dev dependency). |
| PulsarApp/package-lock.json | Lockfile updated; reflects RN library version metadata and new dev dependency. |
| PulsarApp/eslint.config.js | Configures unused-imports plugin and rules on top of Expo flat config. |
| docs/package-lock.json | Lockfile churn from re-install (optional/devOptional metadata changes). |
| CONTRIBUTING.md | Documents npm run install:all and new root lint commands; removes repeated per-package npm install steps. |
| .gitignore | Updates ignore patterns (includes a suspicious new mlekoscripts entry). |
Files not reviewed (3)
- PulsarApp/package-lock.json: Language not supported
- docs/package-lock.json: Language not supported
- react-native/react-native-pulsar/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: