Skip to content

added scripts, updated contributing.md, fixed install issues#20

Open
tshmieldev wants to merge 1 commit intomainfrom
@tshmieldev/add-lint
Open

added scripts, updated contributing.md, fixed install issues#20
tshmieldev wants to merge 1 commit intomainfrom
@tshmieldev/add-lint

Conversation

@tshmieldev
Copy link
Copy Markdown
Member

Added:

  • Scripts (install, lint)
  • Basic eslint config
  • fixed an issue when doing npm i in pulsarApp (now it works if you run npm run install:all in root)
  • updated contributing.md to include this change

Copilot AI review requested due to automatic review settings April 20, 2026 15:24
@tshmieldev tshmieldev requested a review from piaskowyk April 20, 2026 15:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a root-level developer workflow for installing JS/TS dependencies and running linters across the monorepo, while updating ESLint configs to enforce unused import cleanup and documenting the new setup in CONTRIBUTING.

Changes:

  • Added root package.json scripts and scripts/*.sh helpers for install:all and multi-language linting.
  • Updated ESLint configs in PulsarApp and react-native-pulsar to use eslint-plugin-unused-imports.
  • Updated CONTRIBUTING.md to direct contributors to the root install/lint workflow; lockfiles updated accordingly.

Reviewed changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/lint.sh Aggregates JS/TS, Kotlin, and Swift lint scripts into one command.
scripts/lint-js.sh Runs ESLint in PulsarApp and the RN library via npm --prefix.
scripts/lint-kotlin.sh Adds ktlint invocation for Android and RN-Android Kotlin sources.
scripts/lint-swift.sh Adds swiftlint invocation for iOS SDK and RN-iOS sources.
scripts/install.sh Installs dependencies in RN lib, PulsarApp, and docs from repo root.
package.json Introduces root “orchestrator” scripts (install:all, lint:*).
react-native/react-native-pulsar/package.json Adds eslint-plugin-unused-imports (dev dependency).
react-native/react-native-pulsar/package-lock.json Lockfile updated for new dev dependency and version metadata.
react-native/react-native-pulsar/eslint.config.mjs Configures unused-imports plugin and rules; disables base unused-vars rules.
react-native/react-native-pulsar/.npmrc Adds legacy-peer-deps=true to change npm install behavior.
PulsarApp/package.json Adds eslint-plugin-unused-imports (dev dependency).
PulsarApp/package-lock.json Lockfile updated; reflects RN library version metadata and new dev dependency.
PulsarApp/eslint.config.js Configures unused-imports plugin and rules on top of Expo flat config.
docs/package-lock.json Lockfile churn from re-install (optional/devOptional metadata changes).
CONTRIBUTING.md Documents npm run install:all and new root lint commands; removes repeated per-package npm install steps.
.gitignore Updates ignore patterns (includes a suspicious new mlekoscripts entry).
Files not reviewed (3)
  • PulsarApp/package-lock.json: Language not supported
  • docs/package-lock.json: Language not supported
  • react-native/react-native-pulsar/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread react-native/react-native-pulsar/.npmrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants