feat(envs): add akamai-functions@1.0#5
Conversation
|
|
||
| [metadata.templates] | ||
| url = "https://github.com/vdice/akamai-functions-spin-templates" | ||
| tag = "v1.0.0-rc.1" |
There was a problem hiding this comment.
Is there value in having a tag here, rather than tracking main? I guess maybe it allows AF to be more conscious about moving templates forward, but I worry that tagging templates plus revving the env will be a piece of admin overhead that gets forgotten...
There was a problem hiding this comment.
My understanding is that AF is unversioned?
|
Also re naming: the expectation with env names is that users will type them in (Although I think we will have completions for env names so maybe it's okay!) |
Signed-off-by: Vaughn Dice <vdice@akamai.com>
7d33626 to
7abe4de
Compare
|
|
||
| [metadata.templates] | ||
| url = "https://github.com/vdice/akamai-functions-spin-templates" | ||
| tag = "v1.0.0-rc.1" |
There was a problem hiding this comment.
i think a tag may be needed. For example, if we add back in the python template (ref akamai-developers/akamai-functions-spin-templates#4 (comment)), without tagging here, we'd need to bump the worlds here before merging that to main in order to ensure the environment config works together.
|
|
||
| [triggers.http] | ||
| worlds = [ | ||
| {reference = "ghcr.io/vdice/akamai/functions:1.0.0", world = "akamai:functions/http-trigger@1.0.0"}, |
There was a problem hiding this comment.
do we anticipate this list ever getting longer? my understanding is no -- we will just update this akamai:functions/http-trigger@v world version
There was a problem hiding this comment.
I'm not sure; tagging @fibonacci1729 and @itowlson who concocted this set for the AF world. If the list were liable to change, would that imply we'd indeed want this env toml versioned?
There was a problem hiding this comment.
I don't think this list will change and if it did that would imply the WIT package added a new world which would prompt a new environment (e.g. akamai-functions@1.1 or ...@2.0)
Draft for now while still in testing mode using my fork/ghcr.io, etc. However, I figured it would be useful to have this up as a reference when considering the broader Akamai Functions env and templates versioning strategy (eg akamai-developers/akamai-functions-spin-templates#3).
Also, hoping for input on what information should live under thedone: no capabilities required currentlycapabilitiesconfiguration -- and/or spots to update/change/add/etc.If keen, you can test the flow with this config and the templates on my fork via:
spin new -E https://raw.githubusercontent.com/vdice/spin-environments/7d3362639aab2ef56b85e486b606a42099e48e20/envs/akamai-functions/akamai-functions%401.0.toml