Skip to content

feat(envs): add akamai-functions@1.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vdice wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(envs): add akamai-functions@1.0 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions envs/akamai-functions/akamai-functions@1.0.toml
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@itowlson itowlson Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that AF is unversioned?

Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
default = { worlds = ["akamai:functions/platform@1.0.0"] }

[triggers]

[triggers.http]
worlds = [
{reference = "ghcr.io/vdice/akamai/functions:1.0.0", world = "akamai:functions/http-trigger@1.0.0"},
Copy link
Copy Markdown

@kate-goldenring kate-goldenring Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we anticipate this list ever getting longer? my understanding is no -- we will just update this akamai:functions/http-trigger@v world version

Copy link
Copy Markdown
Contributor Author

@vdice vdice Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure; tagging @fibonacci1729 and @itowlson who concocted this set for the AF world. If the list were liable to change, would that imply we'd indeed want this env toml versioned?

Copy link
Copy Markdown

@fibonacci1729 fibonacci1729 Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this list will change and if it did that would imply the WIT package added a new world which would prompt a new environment (e.g. akamai-functions@1.1 or ...@2.0)

{reference = "ghcr.io/vdice/akamai/functions:1.0.0", world = "akamai:functions/http-trigger-rc20231018@1.0.0"},
{reference = "ghcr.io/vdice/akamai/functions:1.0.0", world = "akamai:functions/http-trigger-rc20231110@1.0.0"},
{reference = "ghcr.io/vdice/akamai/functions:1.0.0", world = "akamai:functions/http-trigger-legacy@1.0.0"}
]

[metadata]

[metadata.templates]
url = "https://github.com/vdice/akamai-functions-spin-templates"
tag = "v1.0.0-rc.1"
Copy link
Copy Markdown
Contributor

@itowlson itowlson Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there value in having a tag here, rather than tracking main? I guess maybe it allows AF to be more conscious about moving templates forward, but I worry that tagging templates plus revving the env will be a piece of admin overhead that gets forgotten...

Copy link
Copy Markdown

@kate-goldenring kate-goldenring Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a tag may be needed. For example, if we add back in the python template (ref akamai-developers/akamai-functions-spin-templates#4 (comment)), without tagging here, we'd need to bump the worlds here before merging that to main in order to ensure the environment config works together.