Make AppInspect actually fail on error#782
Open
Ickerday wants to merge 2 commits into
Open
Conversation
Ickerday
force-pushed
the
cicd/add-ci-flag-to-appinspect-stage
branch
from
3a43eb7 to
c4d002d
Compare
Ickerday
force-pushed
the
cicd/add-ci-flag-to-appinspect-stage
branch
from
c4d002d to
e0ad3bb
Compare
mateusz834
force-pushed
the
cicd/add-ci-flag-to-appinspect-stage
branch
from
e0ad3bb to
56680ee
Compare
mateusz834
approved these changes
May 26, 2026
Merged
Ickerday
force-pushed
the
cicd/add-ci-flag-to-appinspect-stage
branch
from
56680ee to
3bce54e
Compare
Ickerday
changed the title
… follow UNIX conventions
szykol
reviewed
Jun 19, 2026
| uvx splunk-appinspect inspect \ | ||
| ./tests/system/test_apps/generating_app/mock_app.tgz \ | ||
| --included-tags cloud --ci || exit_code=$? | ||
| [ "${exit_code:-0}" -ne 101 ] || exit 1 |
Collaborator
There was a problem hiding this comment.
curious whether we should handle the generic exit code = 1 as well here. Unless appinspect never returns it - just so the job doesn't fail quietly
mateusz834
reviewed
Jun 19, 2026
| uvx splunk-appinspect inspect \ | ||
| ./tests/system/test_apps/generating_app/mock_app.tgz \ | ||
| --included-tags cloud --ci || exit_code=$? | ||
| [ "${exit_code:-0}" -ne 101 ] || exit 1 |
Member
There was a problem hiding this comment.
I have a hard time understanding what this even does.
I would like to know what error coudes would cause the CI to fail and which not.
mateusz834
reviewed
Jun 19, 2026
| run: uvx splunk-appinspect inspect ./tests/system/test_apps/generating_app/mock_app.tgz --included-tags cloud | ||
| run: | | ||
| # AppInspect doesn't follow UNIX conventions so we swallow all non-zero | ||
| # exit codes unless its 101, the de facto error code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.