Skip to content

Make AppInspect actually fail on error #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ickerday wants to merge 3 commits into
base: develop
Choose a base branch
from
+12 −1
Open

Make AppInspect actually fail on error #782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bce54e
Test AppInspect with --ci flag
Ickerday Jun 18, 2026
b26b2be
Swallow every non-zero exit code other than 101 as AppInspect doesn't…
Ickerday Jun 18, 2026
20cf0a1
Redo the ęxit code handling in appinspect
Ickerday Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/actions/run-appinspect/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,15 @@ runs:
tar -czf mock_app.tgz --exclude="__pycache__" bin default metadata
- name: Validate the mock app with AppInspect
shell: bash
run: uvx splunk-appinspect inspect ./tests/system/test_apps/generating_app/mock_app.tgz --included-tags cloud
run: |
# AppInspect doesn't follow UNIX conventions, gotta handle their exit codes explicitly
Comment thread
mateusz834 marked this conversation as resolved.
# https://dev.splunk.com/enterprise/reference/appinspect/appinspectcliref#inspect
uvx splunk-appinspect inspect \
./tests/system/test_apps/generating_app/mock_app.tgz \
--included-tags cloud --ci || exit_code=$?
case "${exit_code:-0}" in
0) ;; # all checks passed
103) ;; # warnings (--ci)
104) ;; # future-tag warnings (--ci)
*) exit "${exit_code}" ;; # 101=failures, 1=packaging, 2=exception, 3=error, etc.
esac
Loading