fix(#8): sign with cosign --new-bundle-format#14
Merged
Conversation
cosign sign-blob --bundle writes the LEGACY bundle format
({base64Signature,cert,rekorBundle}), which sigstore-go — and thus spawn — can't
parse. --new-bundle-format emits the Sigstore protobuf bundle
(application/vnd.dev.sigstore.bundle.v0.3+json) that spawn verifies.
Caught by re-cutting rstudio-server-v1.0.1 through the real workflow: spawn
v0.86.0 rejected the signature ('unknown field base64Signature'). Re-signed
locally with --new-bundle-format → spawn verified it (signature-verified) against
the production sigstore trust root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosign sign-blob --bundle(without--new-bundle-format) writes the legacy bundle format ({base64Signature,cert,rekorBundle}), whichsigstore-go— and thereforespawn's verifier — cannot parse.--new-bundle-formatemits the Sigstore protobuf bundle (application/vnd.dev.sigstore.bundle.v0.3+json) that spawn verifies.How it was caught
Re-cutting
rstudio-server-v1.0.1through the real (now-merged) signing workflow produced a legacy bundle;spawn v0.86.0rejected it withproto: unknown field "base64Signature". Re-signing the same manifest locally with--new-bundle-format→spawn plugin inspect rstudio-server@v1.0.1showssignature-verified ✓against the production sigstore trust root (Fulcio + Rekor + SCT + timestamp).The virtual-Sigstore unit tests use protobuf entities, so they never exercised this legacy path — hence it slipped past. Companion spawn PR adds a clear error if a legacy bundle ever reaches the verifier: spore-host/spawn#421.
Refs #8.