🖌 Image setup and styling#2400
Open
JFWooten4 wants to merge 4 commits intostellar:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds global image corner rounding styles for Markdown-rendered documentation, with an opt-out class and separate rounding for GIFs.
Changes:
- Apply default border-radius to
.markdown img - Add an opt-out via
.no-rounding - Increase rounding for GIF images via
srcattribute selectors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few images to set up new documentation for #635. It also adds back in a really detailed orderbook diagram from https://github.com/stellar/stellar-docs/pull/1403/files#diff-9b34426fa11233f1e84efec577692ec470b6110c97936eff40f7ae64c03c2f47. I'll use all these in my page updates (as an aside, nowhere else really dives into the sheep-wheat syntax, so I'm glad we have these).
Lastly, the existing images were really sharp and jarring on my screen viewers, especially when their background color differs from the reader's light or dark mode. I softened the images across the docs with a light but oh-so-easing corner rounding. It's slightly more curved on GIFs since all the existing video embeds have a lot of screenshare padding space.