Update mixed min block time test to use 4 profiles + network tuning#381
Merged
marta-lokhova merged 1 commit intostellar:mainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MinBlockTimeMixed mission to run against the new overlay-only MIXED_PREGEN_* stellar-core loadgen modes, including stream-specific TPS controls and associated network limit tuning.
Changes:
- Add
MIXED_PREGEN_*loadgen modes + per-stream TPS fields (classicTxRate/sorobanTxRate) and plumb them through CLI + mission context. - Update min-block-time mixed mission/test flow to (a) scale Soroban limits for the selected synthetic Soroban tx type and (b) toggle overlay-only mode during measurement load.
- Improve multi-peer loadgen partitioning to support stream-specific rates and skip zero-rate peers; adjust docs accordingly.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/FSLibrary/StellarStatefulSets.fs | Adds DeployUpgradeEntriesAndArmAfter; updates RunMultiLoadgen to split/filter stream-specific rates. |
| src/FSLibrary/StellarMissionContext.fs | Extends MissionContext with mixed-mode config and per-stream TPS options. |
| src/FSLibrary/StellarCoreHTTP.fs | Adds new loadgen modes, helpers for mixed pregen mode parsing, new loadgen query params, and overlay-only toggle endpoint. |
| src/FSLibrary/MissionMinBlockTimeMixed.fs | Switches mixed min-block-time mission to overlay-only MIXED_PREGEN_* modes and configures classic/soroban TPS split. |
| src/FSLibrary/MinBlockTimeTest.fs | Implements mixed-pregen Soroban limit scaling + overlay-only toggling in the min-block-time search loop. |
| src/FSLibrary.Tests/Tests.fs | Updates test MissionContext construction for new required fields. |
| src/App/Program.fs | Adds CLI flags for mixed pregen mode + per-stream TPS; increases default probe timeout. |
| doc/missions.md | Updates mission description for new mixed pregen overlay-only behavior. |
| doc/measuring-minimum-block-time.md | Updates documentation for new mixed pregen options and behavior (needs multiplier correction). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marta-lokhova
force-pushed
the
MixedLoadMinBlockTimeTest
branch
from
d8a25ad to
f89a5af
Compare
dmkozh
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: #382 (requires some core changes)