fix: Incorrect bounding box for sprites with non-default Center#3228
Open
w0wca7a wants to merge 1 commit into
Open
fix: Incorrect bounding box for sprites with non-default Center#3228w0wca7a wants to merge 1 commit into
w0wca7a wants to merge 1 commit into
Conversation
Fix incorrect bounding box for sprites with non-default Center
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
When a sprite's pivot is offset from the geometric center of the texture (e.g. anchoring the sprite to its bottom edge so it sits on the ground), the sprite is rendered visually shifted relative to the entity's position — but the bounding box used for frustum culling stays centered on the entity itself.
Related Issue
fixes: #3227
Types of changes
Checklist