Skip to content

fix: Incorrect bounding box for sprites with non-default Center #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
w0wca7a wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Incorrect bounding box for sprites with non-default Center #3228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sources/engine/Stride.Rendering/Rendering/Sprites/RenderSprite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,21 @@ internal void CalculateBoundingBox()
Vector3 halfBoxSize;
var boxWorldPosition = WorldMatrix.TranslationVector;

if (Sprite != null)
{
var sourceRegion = Sprite.RegionInternal;
var normalizedCenter = new Vector2(
Sprite.Center.X / sourceRegion.Width - 0.5f,
0.5f - Sprite.Center.Y / sourceRegion.Height);

var centerOffset = Vector2.Modulate(normalizedCenter, Sprite.SizeInternal);

// Apply the same offset as the render - move the center box
boxWorldPosition.X -= centerOffset.X * WorldMatrix.M11 + centerOffset.Y * WorldMatrix.M21;
boxWorldPosition.Y -= centerOffset.X * WorldMatrix.M12 + centerOffset.Y * WorldMatrix.M22;
boxWorldPosition.Z -= centerOffset.X * WorldMatrix.M13 + centerOffset.Y * WorldMatrix.M23;
}

if (SpriteType == SpriteType.Billboard)
{
// Make a gross estimation here as we don't have access to the camera view matrix
Expand Down