Extract matchByName() utility and refactor resolve logic#79
Closed
titouanmathis wants to merge 2 commits intofeature/70-resolve-actionfrom
Closed
Extract matchByName() utility and refactor resolve logic#79titouanmathis wants to merge 2 commits intofeature/70-resolve-actionfrom
titouanmathis wants to merge 2 commits intofeature/70-resolve-actionfrom
Conversation
Add a resolve action to servers and sites that accepts a name/query and returns matching resources via partial case-insensitive search. Exact match returns single result, partial returns all candidates. Extracted matching logic into forge-core executors so both CLI and MCP can share the resolution logic. Closes #70 Co-authored-by: Claude <claude@anthropic.com>
Extract shared case-insensitive name matching into a reusable matchByName() utility in forge-core. Refactor both core resolve executors and CLI resolve functions to use it, eliminating duplicated matching logic. Closes #74 Co-authored-by: Claude <claude@anthropic.com>
titouanmathis
force-pushed
the
feature/70-resolve-action
branch
from
8cbae95 to
9455eab
Compare
Contributor
Author
|
Retargeted to main after #72 merged. Rebased cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #74 — extracts shared name matching into a reusable utility.
Changes
Core
matchByName<T>()utility inpackages/core/src/utils/name-matcher.ts{ exact: T[], partial: T[] }for flexible consumption@studiometa/forge-corepublic APIresolveServers()andresolveSites()executors to use itCLI
resolveServerId()andresolveSiteId()to usematchByName()from coreTests
matchByName()Closes #74