refactor: Round 12 — lazy imports, dead code cleanup#81
Open
t0ugh-sys wants to merge 2 commits into
Open
Conversation
Round 12 — extract _read_messages() helper from JsonlTeamInboxStore. drain() and peek() had identical 10-line JSONL reading blocks. Now both delegate to _read_messages(), cutting ~15 lines. 300/300 tests passing.
…s/team_runtime/cli - __init__.py: convert 28 eager submodule imports to lazy __getattr__ pattern, reducing import startup cost significantly - skills.py: remove dead _skill_doc_path and _legacy_skill_doc_path wrappers - team_runtime.py: remove unused plan_approval_response enum value - cli.py: remove unused Dict import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Lazy-load submodules in
__init__.py(biggest win)from . import Xto lazy__getattr__patternimport anvilstartup timeTYPE_CHECKINGblock preserves IDE autocompletion2. Dead code removal
_skill_doc_path()and_legacy_skill_doc_path()wrappers (only the_for_rootvariants are actually called)plan_approval_responseenum value fromTeamMessageTypeDictimport from typingCumulative stats (Rounds 2–12)
__all__