fix(deep-link): filter out web links instead of app links in deep link domains#3382
Open
Amjad50 wants to merge 3 commits into
Open
fix(deep-link): filter out web links instead of app links in deep link domains#3382Amjad50 wants to merge 3 commits into
Amjad50 wants to merge 3 commits into
Conversation
Amjad50
force-pushed
the
fix-deeplink-regression-ios
branch
from
dd7015f to
208230d
Compare
Amjad50
force-pushed
the
fix-deeplink-regression-ios
branch
2 times, most recently
from
6faa97f to
168870a
Compare
…k domains This fixes a bug where on ios, deeplinks just don't work because the final Info.plist file doesn't have them. And also used a better id for CFBundleURLName Fixes regression from 2804803
Amjad50
force-pushed
the
fix-deeplink-regression-ios
branch
from
168870a to
39e9db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where on ios, deeplinks just don't work because the final Info.plist file doesn't have them. And also used a better id for CFBundleURLName
Fixes regression from 2804803