Skip to content

fix(deep-link): filter out web links instead of app links in deep link domains #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amjad50 wants to merge 3 commits into
base: v2
Choose a base branch
from
+20 −3
Open

fix(deep-link): filter out web links instead of app links in deep link domains #3382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c853181
fix(deep-link): filter out web links instead of app links in deep lin…
Amjad50 Apr 9, 2026
fb0f2f2
feat(deep-link): add `webcredentials:` for iOS entitlements file
Amjad50 May 1, 2026
39e9db2
chore: added changelog for deep-link patch
Amjad50 May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changes/fix-deep-link-ios-url-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"deep-link": patch
---

Fixed an iOS regression where deep link URL types were generated from app links instead of custom URL schemes, which could prevent custom schemes from being registered correctly.

Also updated the generated iOS `CFBundleURLName` to use `$(PRODUCT_BUNDLE_IDENTIFIER).{scheme}`.

And added handling for `webcredentials:` in iOS entitlements

13 changes: 10 additions & 3 deletions plugins/deep-link/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,13 @@ fn main() {
.iter()
.filter(|d| d.is_app_link())
.filter_map(|d| d.host.as_ref())
.map(|host| format!("applinks:{}", host).into())
.flat_map(|host| {
[
format!("applinks:{}", host),
format!("webcredentials:{}", host),
]
})
.map(Into::into)
.collect::<Vec<_>>()
.into(),
);
Expand All @@ -139,7 +145,7 @@ fn main() {
let deep_link_domains = config
.mobile
.iter()
.filter(|domain| !domain.is_app_link())
.filter(|domain| !domain.is_web_link())
.collect::<Vec<_>>();

if deep_link_domains.is_empty() {
Expand Down Expand Up @@ -173,7 +179,8 @@ fn main() {
);
dict.insert(
"CFBundleURLName".into(),
domain.scheme[0].clone().into(),
format!("$(PRODUCT_BUNDLE_IDENTIFIER).{}", domain.scheme[0])
.into(),
);
plist::Value::Dictionary(dict)
})
Expand Down