Migrate table-delete + table-restore onto lifecycle driver#51
Merged
Conversation
Add framework/runners/table-lifecycle.ts (runTableSamplesLifecycle), the non-link sibling of runTableLinkSamplesLifecycle. The driver owns the shared archive/restore sample loop for plain tables: fixture prep, the per-sample iteration, aggregation through buildTableLifecycleSamplesResult, the diagnostic error path, and the cleanup short-circuit. The table-delete and table-restore runners now declare only what varies for each kind (per-sample request + verification, success-only details, cleanup policy). This mirrors the already-migrated link family (table-delete-link / table-restore-link on table-link-lifecycle.ts); two members justify the generic non-link family driver. Behavior is artifact-identical, proven by the G1 diff over both cases x v1/v2: baselineA<->baselineB and baselineA<->candidate all pass; perturbing phases[0].name or thresholds[0].metric fails the diff. pnpm check passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the
table-deleteandtable-restorerunner kinds onto a lifecycle driver, mirroring the already-migrated link family (table-delete-link/table-restore-linkontable-link-lifecycle.ts).framework/runners/table-lifecycle.ts—runTableSamplesLifecycle, the non-link sibling ofrunTableLinkSamplesLifecycle. Owns the shared protocol for plain (linkless) table archive/restore: fixture prep, the per-sample iteration loop, aggregation viabuildTableLifecycleSamplesResult, the diagnostic error path, and the cleanup short-circuit.table-delete.runner.ts/table-restore.runner.tsnow declare only what varies per kind (per-sample request + verification, success-only details, cleanup policy). Export names are unchanged, soregistry.tsis untouched.tasks/runner-migration-tracker.md— both kinds moved to Migrated; counts updated8/35 → 10/35 runner kinds · 10/55 → 12/55 cases.Two members (delete + restore) justify the generic non-link family driver per the runner-framework rule #6.
Cases covered
table-delete/10k-20f(runner kindtable-delete)table-restore/10k-20f(runner kindtable-restore)Verification (local)
pnpm check✅ (exit 0)phases[0].nameandthresholds[0].metricboth fail the diff.cases/**,registry.ts,framework/types.ts,framework/artifacts.ts, or../teable-ee.CI acceptance via GitHub Actions (
teable-ee-e2e-perf.yml, this branch ref, v1+v2) is being run before merge.🤖 Generated with Claude Code