Skip to content

Migrate table-delete + table-restore onto lifecycle driver #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HynLcc merged 1 commit into from
Jun 18, 2026
Merged

Migrate table-delete + table-restore onto lifecycle driver #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
301 changes: 141 additions & 160 deletions framework/runners/table-delete.runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,195 +2,177 @@ import { permanentDeleteTable } from "../../../utils/init-app";
import { isExecuteDbIsolated } from "../env";
import { measureAsync } from "../metrics";
import { withPerfTraceStep } from "../trace-collector";
import type {
PerfCase,
PerfRunContext,
PerfRunResult,
TableDeleteCaseConfig,
} from "../types";
import { PerfRunDiagnosticError } from "../types";
import {
waitForRowsRestored,
type Measurement,
type RecordReplayVerification,
} from "./record-undo-redo.shared";
import type { PerfCase, PerfRunContext, PerfRunResult } from "../types";
import { waitForRowsRestored } from "./record-undo-redo.shared";
import { runTableSamplesLifecycle } from "./table-lifecycle";
import {
archiveTable,
assertTableNotListed,
buildTableLifecycleSampleResult,
buildTableLifecycleSamplesResult,
findTableTrashId,
formatTableLifecycleSample,
prepareTableLifecycleFixtures,
restoreTableTrash,
seedTableLifecycleCase,
type TableLifecycleCaseConfig,
type TableLifecycleCleanupSample,
type TableLifecycleFixtureSample,
type TableLifecycleRequestSample,
type TableLifecycleVerifySample,
type TableTrashLookup,
} from "./table-lifecycle.shared";

// Restore the archived table and confirm its full row count, so a reusable seed
// stays intact for the next run; the restore is recorded as a cleanup sample.
const restoreDeletedSample = async ({
context,
perfCase,
config,
sample,
trashId,
cleanupSamples,
}: {
context: PerfRunContext;
perfCase: PerfCase;
config: TableLifecycleCaseConfig;
sample: TableLifecycleFixtureSample;
trashId: string;
cleanupSamples: TableLifecycleCleanupSample[];
}) => {
const sampleLabel = formatTableLifecycleSample(sample.iteration);
const restoreMeasurement = await withPerfTraceStep(
context,
perfCase,
`cleanupRestoreTable-${sampleLabel}`,
() =>
measureAsync(`cleanupRestoreTable-${sampleLabel}`, () =>
restoreTableTrash(trashId),
),
);
const verifyMeasurement = await measureAsync(
`cleanupFullScan-${sampleLabel}`,
() => waitForRowsRestored(sample.fixture, config),
);
cleanupSamples.push({
iteration: sample.iteration,
restoreMeasurement,
verifyMeasurement,
});
};

export const runTableDeleteCase = async (
perfCase: PerfCase,
context: PerfRunContext,
): Promise<PerfRunResult> => {
const config = perfCase.config as TableDeleteCaseConfig;
const baseId = globalThis.testConfig.baseId;
let fixtureSamples: TableLifecycleFixtureSample[] = [];
const requestSamples: TableLifecycleRequestSample[] = [];
const verifySamples: TableLifecycleVerifySample[] = [];
const cleanupSamples: TableLifecycleCleanupSample[] = [];

const restoreDeletedSample = async (
sample: TableLifecycleFixtureSample,
trashId: string,
) => {
const sampleLabel = formatTableLifecycleSample(sample.iteration);
const restoreMeasurement = await withPerfTraceStep(
context,
perfCase,
`cleanupRestoreTable-${sampleLabel}`,
() =>
measureAsync(`cleanupRestoreTable-${sampleLabel}`, () =>
restoreTableTrash(trashId),
),
);
const verifyMeasurement = await measureAsync(
`cleanupFullScan-${sampleLabel}`,
() => waitForRowsRestored(sample.fixture, config),
);
cleanupSamples.push({
iteration: sample.iteration,
restoreMeasurement,
verifyMeasurement,
});
return verifyMeasurement;
};

try {
fixtureSamples = await prepareTableLifecycleFixtures(
baseId,
config,
perfCase,
"table-delete",
);
): Promise<PerfRunResult> =>
runTableSamplesLifecycle(perfCase, context, {
runner: "table-delete",
includeCleanupSamples: true,
buildDetails: ({ config, state, error }): Record<string, unknown> =>
error
? {}
: {
cleanup: {
restoredSamples: state.cleanupSamples.filter(
(sample) =>
sample.verifyMeasurement?.result.scannedRecords ===
config.rowCount,
).length,
fullScans: state.cleanupSamples.map((sample) => ({
iteration: sample.iteration,
restoreStatus: sample.restoreMeasurement?.result.status,
restoreRequestMs: sample.restoreMeasurement?.durationMs,
fullScan: sample.verifyMeasurement?.result,
})),
},
verification: {
metric: "verifyMs",
checks: [
"tableAbsentFromBaseTableList",
"trashItemPresent",
"cleanupRestoreFullRowCountScan",
],
participatesInThreshold: false,
},
},
runSample: async ({ perfCase, context, config, baseId, sample, state }) => {
const sampleLabel = formatTableLifecycleSample(sample.iteration);
const requestMeasurement = await withPerfTraceStep(
context,
perfCase,
`deleteTable-${sampleLabel}`,
() =>
measureAsync(`deleteTable-${sampleLabel}`, () =>
archiveTable(baseId, sample.fixture.tableId),
),
);

try {
for (const sample of fixtureSamples) {
const sampleLabel = formatTableLifecycleSample(sample.iteration);
const requestMeasurement = await withPerfTraceStep(
const verifyMeasurement = await withPerfTraceStep(
context,
perfCase,
`deleteTableVerify-${sampleLabel}`,
() =>
measureAsync(`deleteTableVerify-${sampleLabel}`, async () => {
const listing = await assertTableNotListed(
baseId,
sample.fixture.tableId,
);
const trashLookup = await findTableTrashId(
baseId,
sample.fixture.tableId,
);
return { ...listing, trashLookup };
}),
);
const { trashLookup } = verifyMeasurement.result as {
trashLookup: TableTrashLookup;
};
state.requestSamples.push(
buildTableLifecycleSampleResult(
sample.iteration,
sample.fixture,
requestMeasurement,
"deleteTable",
context,
perfCase,
`deleteTable-${sampleLabel}`,
() =>
measureAsync(`deleteTable-${sampleLabel}`, () =>
archiveTable(baseId, sample.fixture.tableId),
),
);
trashLookup,
),
);
state.verifySamples.push({
iteration: sample.iteration,
measurement: verifyMeasurement,
});

const verifyMeasurement = await withPerfTraceStep(
if (!isExecuteDbIsolated()) {
await restoreDeletedSample({
context,
perfCase,
`deleteTableVerify-${sampleLabel}`,
() =>
measureAsync(`deleteTableVerify-${sampleLabel}`, async () => {
const listing = await assertTableNotListed(
baseId,
sample.fixture.tableId,
);
const trashLookup = await findTableTrashId(
baseId,
sample.fixture.tableId,
);
return { ...listing, trashLookup };
}),
);
const { trashLookup } = verifyMeasurement.result as {
trashLookup: Awaited<ReturnType<typeof findTableTrashId>>;
};
requestSamples.push(
buildTableLifecycleSampleResult(
sample.iteration,
sample.fixture,
requestMeasurement,
"deleteTable",
context,
trashLookup,
),
);
verifySamples.push({
iteration: sample.iteration,
measurement: verifyMeasurement,
config,
sample,
trashId: trashLookup.trashId,
cleanupSamples: state.cleanupSamples,
});

if (!isExecuteDbIsolated()) {
await restoreDeletedSample(sample, trashLookup.trashId);
}
}
} catch (error) {
throw new PerfRunDiagnosticError(
error instanceof Error ? error.message : String(error),
buildTableLifecycleSamplesResult({
config,
runner: "table-delete",
fixtureSamples,
requestSamples,
verifySamples,
cleanupSamples,
error,
}),
);
}
},
cleanup: async ({ perfCase, context, config, baseId, state }) => {
if (isExecuteDbIsolated()) {
return;
}

return buildTableLifecycleSamplesResult({
config,
runner: "table-delete",
fixtureSamples,
requestSamples,
verifySamples,
cleanupSamples,
details: {
cleanup: {
restoredSamples: cleanupSamples.filter(
(sample) =>
sample.verifyMeasurement?.result.scannedRecords ===
config.rowCount,
).length,
fullScans: cleanupSamples.map((sample) => ({
iteration: sample.iteration,
restoreStatus: sample.restoreMeasurement?.result.status,
restoreRequestMs: sample.restoreMeasurement?.durationMs,
fullScan: sample.verifyMeasurement?.result,
})),
},
verification: {
metric: "verifyMs",
checks: [
"tableAbsentFromBaseTableList",
"trashItemPresent",
"cleanupRestoreFullRowCountScan",
],
participatesInThreshold: false,
},
},
});
} finally {
if (!isExecuteDbIsolated()) {
for (const sample of fixtureSamples) {
const requestSample = requestSamples.find(
for (const sample of state.fixtureSamples) {
const requestSample = state.requestSamples.find(
(item) => item.iteration === sample.iteration,
);
const cleanupSample = cleanupSamples.find(
const cleanupSample = state.cleanupSamples.find(
(item) => item.iteration === sample.iteration,
);
let restored = Boolean(cleanupSample?.verifyMeasurement);

if (!restored && requestSample?.trashLookup) {
try {
await restoreDeletedSample(
await restoreDeletedSample({
context,
perfCase,
config,
sample,
requestSample.trashLookup.trashId,
);
trashId: requestSample.trashLookup.trashId,
cleanupSamples: state.cleanupSamples,
});
restored = true;
} catch (error) {
console.warn(
Expand All @@ -211,9 +193,8 @@ export const runTableDeleteCase = async (
}
}
}
}
}
};
},
});

export const seedTableDeleteCase = async (
perfCase: PerfCase,
Expand Down
Loading