chore: update sepolia contracts#1154
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
📝 WalkthroughWalkthroughTwo configuration files updated with deployed contract metadata: CRISP contracts received new addresses and block numbers for CRISPProgram, HonkVerifier, and a new RiscZeroGroth16Verifier entry; EnclaveRegistryOwnable's proxy implementation address was updated across both files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/CRISP/packages/crisp-contracts/deployed_contracts.json (1)
92-92: Critical: Outdated Enclave implementation address.The
implementationAddresshere is0x957C3cbBD33C8Db4D7b7921334FD7A626B672051, but inpackages/enclave-contracts/deployed_contracts.jsonit was updated to0x48A9304e08504e7e76821da3dDe7a199BFd320dD. Since both files reference the same proxy address (0x01E657C16192854E8d7D7055228C7D6532E345Be), they track the same Sepolia deployment and should have consistent implementation addresses.🔧 Proposed fix
- "implementationAddress": "0x957C3cbBD33C8Db4D7b7921334FD7A626B672051" + "implementationAddress": "0x48A9304e08504e7e76821da3dDe7a199BFd320dD"
🧹 Nitpick comments (1)
packages/enclave-contracts/deployed_contracts.json (1)
109-111: Add blockNumber for consistency.The
MockRISC0Verifierentry is missing ablockNumberfield, while other deployed contracts in this file include it. Consider adding the deployment block number for consistency and completeness.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
examples/CRISP/packages/crisp-contracts/deployed_contracts.jsonpackages/enclave-contracts/deployed_contracts.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: cedoor
Repo: gnosisguild/enclave PR: 752
File: packages/enclave-contracts/contracts/Enclave.sol:15-17
Timestamp: 2025-09-19T11:16:53.825Z
Learning: The Enclave contract in the gnosisguild/enclave repository has not been deployed yet as of September 2025, so storage layout considerations for upgradeable contracts don't apply to current changes.
Learnt from: ctrlc03
Repo: gnosisguild/enclave PR: 996
File: examples/CRISP/packages/crisp-contracts/contracts/CRISPProgram.sol:144-169
Timestamp: 2025-11-12T10:08:30.720Z
Learning: In the CRISP program (examples/CRISP/packages/crisp-contracts/contracts/CRISPProgram.sol), there are plans to move the merkle tree from the Enclave contract to the program contract itself in the future, which would allow direct calls to validateInput to be stored in the merkle tree.
📚 Learning: 2025-09-19T11:16:53.825Z
Learnt from: cedoor
Repo: gnosisguild/enclave PR: 752
File: packages/enclave-contracts/contracts/Enclave.sol:15-17
Timestamp: 2025-09-19T11:16:53.825Z
Learning: The Enclave contract in the gnosisguild/enclave repository has not been deployed yet as of September 2025, so storage layout considerations for upgradeable contracts don't apply to current changes.
Applied to files:
packages/enclave-contracts/deployed_contracts.json
📚 Learning: 2025-11-12T10:08:30.720Z
Learnt from: ctrlc03
Repo: gnosisguild/enclave PR: 996
File: examples/CRISP/packages/crisp-contracts/contracts/CRISPProgram.sol:144-169
Timestamp: 2025-11-12T10:08:30.720Z
Learning: In the CRISP program (examples/CRISP/packages/crisp-contracts/contracts/CRISPProgram.sol), there are plans to move the merkle tree from the Enclave contract to the program contract itself in the future, which would allow direct calls to validateInput to be stored in the merkle tree.
Applied to files:
examples/CRISP/packages/crisp-contracts/deployed_contracts.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: integration_prebuild
- GitHub Check: test_net
- GitHub Check: build_crisp_sdk
- GitHub Check: rust_unit
- GitHub Check: build_ciphernode_image
- GitHub Check: build_sdk
- GitHub Check: build_enclave_cli
- GitHub Check: rust_integration
🔇 Additional comments (3)
packages/enclave-contracts/deployed_contracts.json (2)
115-123: Verify if CRISPProgram should reference updated verifiers.The
CRISPProgramin this file references verifier addresses that differ from the newly deployed verifiers inexamples/CRISP/packages/crisp-contracts/deployed_contracts.json. Specifically:
verifierAddresshere:0xd21D7b4A70129A4a20236Df197aDaB2F46E10ec3honkVerifierAddresshere:0x97acc66d62B44623F952423Cf37E3acf312CcE6bWhile in the CRISP contracts file:
- New
RiscZeroGroth16Verifier:0x3E1b9A7d0cc3cB9bc251A3c79415206e666362B4- New
HonkVerifier:0xE553e72A9400785C6dc7aAE6B2a667f0958748F5Verify whether this is intentional (separate deployments) or if this file should also be updated to reference the newly deployed verifiers.
92-92: Fix inconsistent Enclave implementation address across deployment files.Both
packages/enclave-contracts/deployed_contracts.jsonandexamples/CRISP/packages/crisp-contracts/deployed_contracts.jsonreference the same Enclave proxy (0x01E657C16192854E8d7D7055228C7D6532E345Be) on Sepolia, but they record different implementation addresses:
- File 1:
0x48A9304e08504e7e76821da3dDe7a199BFd320dD- File 2:
0x957C3cbBD33C8Db4D7b7921334FD7A626B672051Verify which implementation address is current and update both files accordingly to maintain consistency.
⛔ Skipped due to learnings
Learnt from: cedoor Repo: gnosisguild/enclave PR: 752 File: packages/enclave-contracts/contracts/Enclave.sol:15-17 Timestamp: 2025-09-19T11:16:53.825Z Learning: The Enclave contract in the gnosisguild/enclave repository has not been deployed yet as of September 2025, so storage layout considerations for upgradeable contracts don't apply to current changes.Learnt from: ryardley Repo: gnosisguild/enclave PR: 145 File: packages/ciphernode/evm/src/enclave_sol_reader.rs:87-89 Timestamp: 2024-10-22T03:39:29.448Z Learning: In the `ciphernode` project, specifically in `packages/ciphernode/evm/src/enclave_sol_reader.rs`, the method `EnclaveSolReader::attach` should be retained even if it directly calls `EvmEventReader::attach` without additional processing. Avoid suggesting its removal in future reviews.examples/CRISP/packages/crisp-contracts/deployed_contracts.json (1)
113-129: LGTM! Consistent cross-references in new deployments.The updates to
HonkVerifier,CRISPProgram, and the newRiscZeroGroth16Verifierentry look good. TheCRISPProgramconstructor arguments correctly reference the newly deployed verifier addresses:
verifierAddressmatchesRiscZeroGroth16VerifieraddresshonkVerifierAddressmatchesHonkVerifieraddressBlock numbers are properly recorded for traceability.
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.