chore: update contract addresses and operator guide#1341
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughReplaces Sepolia contract addresses, block numbers, and proxy/initData across documentation and deployment JSONs; bumps CRISP package versions and updates one server minor edit. No API, runtime logic, or exported public declarations changed. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e57d683 to
5d68e80
Compare
5d68e80 to
4969dab
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
examples/CRISP/packages/crisp-contracts/deployed_contracts.json (1)
1-157: Consider whether the base contract section should reference the main file rather than duplicate it.Lines 3–134 (PoseidonT3 → DkgPkVerifier) are an exact copy of
packages/enclave-contracts/deployed_contracts.json. Any future redeployment requires synchronising both files, which is already exactly what this PR does. If the CRISP deployment script can read from the parent package'sdeployed_contracts.json, the base section here could be dropped in favour of a reference.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/CRISP/packages/crisp-contracts/deployed_contracts.json` around lines 1 - 157, The file duplicates the base contracts block (PoseidonT3 through DkgPkVerifier) from packages/enclave-contracts/deployed_contracts.json; update the CRISP package to stop duplicating that data by changing its deployment/resource loading to read/merge from the parent package's deployed_contracts.json (packages/enclave-contracts/deployed_contracts.json) instead of embedding the block for PoseidonT3, MockUSDC, EnclaveToken, EnclaveTicketToken, SlashingManager, BondingRegistry, CiphernodeRegistryOwnable, Enclave, E3RefundManager, MockComputeProvider, MockDecryptionVerifier, MockE3Program, ZKTranscriptLib, DkgPkVerifier; remove the duplicated JSON section from examples/CRISP/packages/crisp-contracts/deployed_contracts.json and ensure any code that accesses crisp-contracts.deployed data now falls back to or imports the parent package data (or adds a simple loader that reads and merges the parent file at runtime/build).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@examples/CRISP/packages/crisp-contracts/deployed_contracts.json`:
- Around line 1-157: The file duplicates the base contracts block (PoseidonT3
through DkgPkVerifier) from packages/enclave-contracts/deployed_contracts.json;
update the CRISP package to stop duplicating that data by changing its
deployment/resource loading to read/merge from the parent package's
deployed_contracts.json (packages/enclave-contracts/deployed_contracts.json)
instead of embedding the block for PoseidonT3, MockUSDC, EnclaveToken,
EnclaveTicketToken, SlashingManager, BondingRegistry, CiphernodeRegistryOwnable,
Enclave, E3RefundManager, MockComputeProvider, MockDecryptionVerifier,
MockE3Program, ZKTranscriptLib, DkgPkVerifier; remove the duplicated JSON
section from examples/CRISP/packages/crisp-contracts/deployed_contracts.json and
ensure any code that accesses crisp-contracts.deployed data now falls back to or
imports the parent package data (or adds a simple loader that reads and merges
the parent file at runtime/build).
- Updated @crisp-e3/sdk to 0.5.12 - Updated @crisp-e3/contracts to 0.5.12 - Updated @crisp-e3/zk-inputs to 0.5.12 - Published to npm
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
examples/CRISP/packages/crisp-contracts/deployed_contracts.json (1)
153-156:MockVotingTokenis missingconstructorArgs.Every other token contract in this file documents its constructor arguments. If
MockVotingTokenwas deployed with any arguments (e.g., initial supply, owner), omitting them means this entry can't be used to reproduce the deployment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/CRISP/packages/crisp-contracts/deployed_contracts.json` around lines 153 - 156, The MockVotingToken entry in deployed_contracts.json is missing constructorArgs; update the "MockVotingToken" object to include a "constructorArgs" key matching the actual deployment parameters (e.g., initial supply, owner) or an empty array if no args were used so the deployment can be reproduced; locate the "MockVotingToken" object and add the constructorArgs field consistent with other token entries in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/CRISP/packages/crisp-contracts/deployed_contracts.json`:
- Around line 84-97: The deployment JSON/TS interface is passing a fifth field
committeeFormationWindow into constructorArgs.timeoutConfig that doesn't exist
on the Solidity side (E3TimeoutConfig in IEnclave.sol) and will break struct
packing; either remove committeeFormationWindow from
constructorArgs.timeoutConfig and any TypeScript interfaces/usages, or update
the Solidity E3TimeoutConfig and _setTimeoutConfig to include and validate
committeeFormationWindow. Locate references to constructorArgs.timeoutConfig,
E3TimeoutConfig, and _setTimeoutConfig (and any TypeScript interface
definitions) and make the change consistently across the deployed_contracts.json
and TypeScript types so the number/order of fields matches the Solidity struct.
---
Nitpick comments:
In `@examples/CRISP/packages/crisp-contracts/deployed_contracts.json`:
- Around line 153-156: The MockVotingToken entry in deployed_contracts.json is
missing constructorArgs; update the "MockVotingToken" object to include a
"constructorArgs" key matching the actual deployment parameters (e.g., initial
supply, owner) or an empty array if no args were used so the deployment can be
reproduced; locate the "MockVotingToken" object and add the constructorArgs
field consistent with other token entries in the file.
Summary by CodeRabbit
Documentation
Chores
Chores