Skip to content

refactor: move user data encryption to bin threshold [skip-line-limit]#1420

Merged
ctrlc03 merged 2 commits into
mainfrom
move/ude
Mar 16, 2026
Merged

refactor: move user data encryption to bin threshold [skip-line-limit]#1420
ctrlc03 merged 2 commits into
mainfrom
move/ude

Conversation

@0xjei

@0xjei 0xjei commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Reorganized the circuit directory structure by consolidating the user data encryption module from a nested wrapper location to a more direct path within the project hierarchy.
    • Updated build compilation scripts and circuit import references across multiple SDK packages and example applications to align with the new directory organization.
    • Refined internal test fixture variable naming for improved code clarity.

@0xjei 0xjei self-assigned this Mar 13, 2026
@vercel

vercel Bot commented Mar 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crisp Ready Ready Preview, Comment Mar 16, 2026 1:52pm
enclave-docs Ready Ready Preview, Comment Mar 16, 2026 1:52pm

Request Review

@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8286adac-59f4-43ab-8b32-9b37ada287b4

📥 Commits

Reviewing files that changed from the base of the PR and between af8c542 and 8b42c68.

📒 Files selected for processing (10)
  • circuits/bin/recursive_aggregation/wrapper/threshold/Nargo.toml
  • circuits/bin/threshold/Nargo.toml
  • circuits/bin/threshold/user_data_encryption/Nargo.toml
  • circuits/bin/threshold/user_data_encryption/src/main.nr
  • examples/CRISP/packages/crisp-sdk/package.json
  • examples/CRISP/packages/crisp-sdk/src/vote.ts
  • examples/CRISP/scripts/compile_circuits.sh
  • packages/enclave-contracts/test/E3Lifecycle/E3Integration.spec.ts
  • packages/enclave-sdk/package.json
  • packages/enclave-sdk/src/crypto/user-data-encryption.ts

📝 Walkthrough

Walkthrough

The pull request relocates the user_data_encryption circuit from a nested wrapper directory structure to a direct subdirectory, updating all corresponding Nargo workspace declarations, build script references, and TypeScript import paths to reflect the new location.

Changes

Cohort / File(s) Summary
Circuit Workspace Configuration
circuits/bin/recursive_aggregation/wrapper/threshold/Nargo.toml, circuits/bin/threshold/Nargo.toml, circuits/bin/threshold/user_data_encryption/Nargo.toml
Removed user_data_encryption from recursive aggregation wrapper workspace; added it to threshold workspace; updated lib dependency path from ../../../../lib to ../../../lib in user_data_encryption Nargo.toml.
Build Script Updates
examples/CRISP/packages/crisp-sdk/package.json, examples/CRISP/scripts/compile_circuits.sh, packages/enclave-sdk/package.json
Updated compile:user_data_encryption script references to point from recursive_aggregation/wrapper/threshold/user_data_encryption to threshold/user_data_encryption.
Runtime Import Path Changes
examples/CRISP/packages/crisp-sdk/src/vote.ts, packages/enclave-sdk/src/crypto/user-data-encryption.ts
Updated circuit import statements to load from threshold/target/user_data_encryption.json instead of wrapper/threshold/target/user_data_encryption.json.
Test Configuration
packages/enclave-contracts/test/E3Lifecycle/E3Integration.spec.ts
Renamed MockCircuitVerifier variable from circuitVerifier to _circuitVerifier in fixture setup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • ctrlc03
  • cedoor

Poem

🐰 A circuit moves from depths so deep,
From wrapper's nest to simpler keep,
Paths shortened, imports rearranged,
The architecture's gently changed,
Now user_data_encryption's free! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving user data encryption module from recursive_aggregation/wrapper/threshold to bin/threshold.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch move/ude
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

cedoor
cedoor previously approved these changes Mar 13, 2026
@ctrlc03 ctrlc03 enabled auto-merge (squash) March 16, 2026 14:19
@ctrlc03 ctrlc03 merged commit f69cb76 into main Mar 16, 2026
27 checks passed
@ctrlc03 ctrlc03 deleted the move/ude branch March 16, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants