Aa ldsc magma#121
Open
LArnoldt wants to merge 15 commits into
Open
Conversation
…dress PR review comments - Merge make_continuous_annot_from_bimfile/donor_data into make_annot_from_bimfile/donor_data via scores= argument; remove the now-redundant continuous-only functions - Add get_magma_gene_loc to _sldsc_utils: fetches Ensembl gene coordinates in MAGMA headless 4-column format, cached to ~/cellink_data/magma/ - Add get_dummy_data_paths and get_dummy_onek1k to resources._datasets; replace all hardcoded machine paths in tutorials with path-free dummy data calls - Update magma_analysis_tutorial.ipynb: remove misplaced continuous S-LDSC Part 1 (belongs in cell_level_ldsc_analysis_updates.ipynb), add MAGMA binary download cell, replace all hardcoded paths (MAGMA_BIN, MAGMA_GENE_LOC, G1000_BFILE) with package downloaders - Update cell_level_ldsc_analysis_updates.ipynb: replace mygene with pybiomart, add binary vs continuous annotation comparison, switch to get_dummy_onek1k - Update cell_level_ldsc_analysis.ipynb: switch to get_dummy_onek1k, remove hardcoded paths - Update test_new_functions.py to match merged API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.