Skip to content

Bump rich>=15.0.0 and Move requirement to cli#267

Merged
timlaing merged 2 commits into
timlaing:mainfrom
PaulCavill:main
May 29, 2026
Merged

Bump rich>=15.0.0 and Move requirement to cli#267
timlaing merged 2 commits into
timlaing:mainfrom
PaulCavill:main

Conversation

@PaulCavill
Copy link
Copy Markdown

Breaking change

Proposed change

Restore "rich" back to version >=15.0.0, and move to CLI install only.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a5a7e89-b220-4e54-8a24-d4f440d41913

📥 Commits

Reviewing files that changed from the base of the PR and between 4ba78d8 and b6d0dd4.

📒 Files selected for processing (1)
  • requirements.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • requirements.txt

📝 Walkthrough

Summary by CodeRabbit

Chores

  • Reorganised project dependencies to separate command-line interface-specific and core functionality requirements.

Walkthrough

The rich dependency is removed from requirements.txt and added to requirements_cli.txt with the version constraint updated from >=13.0.0 to >=15.0.0.

Changes

Dependency Management

Layer / File(s) Summary
Move rich to CLI requirements
requirements.txt, requirements_cli.txt
rich>=13.0.0 is removed from the general requirements and rich>=15.0.0 is added to the CLI-specific requirements, shifting the CLI dependency to a newer rich release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • timlaing/pyicloud#266: Adjusts the rich entry in requirements.txt; directly related to changes managing the rich dependency across requirements files.

Poem

🐰 I hopped through files with a curious twitch,
Moved Rich to the CLI and bumped up its stitch,
From thirteen to fifteen the versions now sing,
A tidy small change — a jaunty spring!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping rich to version >=15.0.0 and moving it from the main requirements to CLI-only requirements.
Description check ✅ Passed The description is directly related to the changeset, clearly stating the intention to restore rich to >=15.0.0 and move it to CLI install only, which matches the file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PaulCavill
Copy link
Copy Markdown
Author

@timlaing Sorry to mess you around on getting around HA version limitation.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@requirements_cli.txt`:
- Line 3: The dependency bump to "rich>=15.0.0" may be breaking because Rich 15
drops Python 3.8 and may introduce API changes; update the PR by either
restoring a compatible lower bound (e.g., pin back to the last safe release used
in this project) or by officially updating the project's supported Python
versions and running/adjusting CLI tests for Rich 15 compatibility;
specifically, change the requirements entry referencing "rich>=15.0.0" to a
version that matches the project’s supported Python runtime or update project
metadata and test suites to confirm the CLI works with Rich 15 and document any
necessary migration fixes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 880bd334-5e38-42bf-a107-1d156718a5a8

📥 Commits

Reviewing files that changed from the base of the PR and between a1db1ca and 4ba78d8.

📒 Files selected for processing (2)
  • requirements.txt
  • requirements_cli.txt
💤 Files with no reviewable changes (1)
  • requirements.txt

Comment thread requirements_cli.txt
@PaulCavill PaulCavill changed the title Bump rich>=15.0.0 and move to cli Bump rich>=15.0.0 and Move requirement to cli May 29, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 29, 2026
@timlaing
Copy link
Copy Markdown
Owner

@timlaing Sorry to mess you around on getting around HA version limitation.

Not a problem, thanks for your help

@timlaing timlaing merged commit ec6df20 into timlaing:main May 29, 2026
12 of 13 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 29, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants