feat(e2e): browser+Docker preflight in global-setup (PP-cao)

[timothyfroehlich]

Summary

Adds two fail-fast checks to e2e/global-setup.ts before the existing Supabase/Postgres pre-flight:

1. checkBrowserBinaries(config) — inspects config.projects to derive needed browsers (chromium/firefox/webkit), verifies each binary exists via existsSync(executablePath()). On miss, throws with Install with: pnpm exec playwright install --with-deps <names>. Only checks browsers the active config actually needs, so CI's chromium-only install isn't penalized.
2. checkDocker() — runs docker info via spawnSync (no shell, fixed argv) with a 5s timeout. On failure: Start OrbStack: open -a OrbStack.

Both checks run regardless of SKIP_SUPABASE_RESET — that flag only skips DB reset/migration/seed; browsers and the Docker daemon are still required to launch Playwright.

Replaces cryptic mid-run failures like browserType.launch: Executable doesn't exist with clear actionable messages before any spec runs.

Also updates the global-setup unit test to pass a mock FullConfig (empty projects array disables the browser check for tests focused on DB orchestration) and mocks spawnSync for the Docker check.

Inherited CI failures

main is currently red. Inherited failures from main (PP-q9r/PP-e20/PP-jsh/PP-v7g/PP-49m) will appear in CI; not introduced by this PR. See Tim's status comment on PR #1278.

Test plan

• pnpm run check passes (1013 unit tests, including updated global-setup tests)
• CI Gate green
• Manual: rename ~/Library/Caches/ms-playwright/chromium-* and confirm fail-fast with install hint
• Manual: stop Docker and confirm fail-fast with OrbStack hint

Related

• Child 3 of epic PP-2on
• Sibling PRs: docs(agents): edit canonical specs in place, no divergence notes (PP-00s) #1281 (docs), feat(worktree): auto-configure branch tracking on post-checkout (PP-ozw) #1282 (worktree tracking), fix(e2e): comment out Turnstile keys in .env.local (PP-uc8 redesign) #1283 (Turnstile)

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
pin-point	Ready	Preview, Comment	May 5, 2026 8:32pm

[supabase]

This pull request has been ignored for the connected project udhesuizjsgxfeotqybn due to reaching the limit of concurrent preview branches.
Go to Project Integrations Settings ↗︎ if you wish to update this limit.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[Copilot]

Pull request overview

Adds fail-fast preflight checks to the Playwright E2E global setup so missing Playwright browser binaries or a down Docker daemon fail immediately with actionable errors (before the existing Supabase/Postgres checks and DB reset/migrations).

Changes:

• Add checkBrowserBinaries(config) to verify required Playwright browser executables exist for the active config’s projects.
• Add checkDocker() to verify docker info succeeds before attempting any Supabase/Postgres orchestration.
• Update unit tests to call globalSetup(config) and mock spawnSync used by the Docker preflight.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
e2e/global-setup.ts	Adds browser-binary and Docker-daemon preflight checks; updates globalSetup signature to accept Playwright FullConfig.
src/test/unit/global-setup.test.ts	Adjusts unit tests for new globalSetup(config) signature and mocks spawnSync.

Comments suppressed due to low confidence (1)

src/test/unit/global-setup.test.ts:120

• This test name/intent no longer matches the implementation: globalSetup now always runs the browser + Docker preflights before checking SKIP_SUPABASE_RESET. Either rename the test (and/or assert the preflights ran) so it reflects the current behavior.

  it("skips everything when SKIP_SUPABASE_RESET is set", async () => {
    process.env.SKIP_SUPABASE_RESET = "true";
    const setup = await loadSetup();

    await setup(EMPTY_CONFIG);

    expect(fetchMock).not.toHaveBeenCalled();
    expect(execSyncMock).not.toHaveBeenCalled();
  });

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/test/unit/global-setup.test.ts:143

• The test case "skips everything when SKIP_SUPABASE_RESET is set" is now misleading/incomplete: globalSetup still runs the Docker (and potentially browser) preflight checks before returning when SKIP_SUPABASE_RESET=true. Consider renaming the test to reflect what is actually skipped and/or add assertions that spawnSync (and the browser check when applicable) is still invoked under SKIP so this contract can’t regress silently.

  it("skips everything when SKIP_SUPABASE_RESET is set", async () => {
    process.env.SKIP_SUPABASE_RESET = "true";
    const setup = await loadSetup();

    await setup(EMPTY_CONFIG);

    expect(fetchMock).not.toHaveBeenCalled();
    expect(execSyncMock).not.toHaveBeenCalled();
  });