[cli] Support cursor pagination for fetching requestIdentifiers#12
Draft
bencmbrook wants to merge 1 commit into
Draft
[cli] Support cursor pagination for fetching requestIdentifiers#12bencmbrook wants to merge 1 commit into
bencmbrook wants to merge 1 commit into
Conversation
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/type-utils
@transcend-io/utils
@transcend-io/mcp
@transcend-io/mcp-server-admin
@transcend-io/mcp-server-assessment
@transcend-io/mcp-server-base
@transcend-io/mcp-server-consent
@transcend-io/mcp-server-discovery
@transcend-io/mcp-server-dsr
@transcend-io/mcp-server-inventory
@transcend-io/mcp-server-preferences
@transcend-io/mcp-server-workflows
commit: |
Member
Author
|
Summary comparing the original transcend-io/cli#533 to the monorepo port tools#12:
Validation on the monorepo port:
Bottom line: the port preserved the original |
iamtheluckyest
added a commit
that referenced
this pull request
Jun 11, 2026
Resolve conflicts from the CLI->SDK move by adopting PR #12's cursor pagination and batched identifier fetching, layered on top of main's withTransientRetry wrapper, logger params, and date-range chunking.
This was referenced Jun 11, 2026
Switch Sombra request-identifier fetching to cursor pagination with batched, parallel lookups across the request set, bounded by a shared connection budget that is divided across --concurrency date-range chunks. Add a --maxIdentifierConcurrency flag to tune the budget, unit tests for fetchRequestIdentifiersBatch, and deprecate the per-request fetchAllRequestIdentifiers.
daa5e7a to
cbcdb27
Compare
Comment on lines
+103
to
+105
| * @deprecated Use {@link fetchRequestIdentifiersBatch} instead, which batches | ||
| * multiple requests into a single paginated call. This per-request variant is | ||
| * retained only for backwards compatibility and has no internal callers. |
Member
There was a problem hiding this comment.
This has no callers in this repo anymore, but my understanding is that it is exposed such that customers could be using it? So I marked it as deprecated, but idk if that's actually what we want to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of transcend-io/cli#533
Summary
requestIdsintoconcurrencygroups per page) instead of one sequential cursor walk.MAX_IDENTIFIER_FETCH_CONCURRENCY, default 200) divided across--concurrencydate-range chunks, so the no-flags default stays competitive and large parallel exports don't overload Sombra. Tunable via the newrequest export --maxIdentifierConcurrencyflag.fetchAllRequestIdentifiersin favor offetchRequestIdentifiersBatch.Context
splitDateRangehelper, merged)Performance (staging, 40,055 requests,
--concurrency 20)mainbaseline (per-request fan-out): ~1122s, and dropped ~25% of requests at single-chunk scale (retry exhaustion from ~2k concurrent connections)daysRemainingfield differs between runs)Test plan
fetchRequestIdentifiersBatch(paging, retry, empty/missing ids, parallel grouping)mainon EU prod (1k) and staging (40k)Made with Cursor