Fix modal dispose scroll reset#42712
Draft
Kevinjohn wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resets the body scrollbar state when disposing a shown modal.
Motivation & Context
Showing a modal adds
modal-opento the body and hides body overflow. Ifdispose()is called while the modal is still shown, the instance is removed but the body scroll lock is left behind.Expected: disposing the shown modal clears the scroll lock it created.
Actual: disposing the shown modal leaves
modal-openon the body and keepsbody.style.overflowset tohidden.This mirrors the normal hide cleanup for the dispose path and adds unit coverage for disposing a shown modal.
Type of changes
Checklist
Actual screenshots
Before disposing the shown modal, the body remains scroll-locked:
After the fix, disposing clears
modal-openand body overflow:Related issues
None.
Checks
git diff --checknpm exec -- eslint --report-unused-disable-directives js/src/modal.js js/tests/unit/modal.spec.jsnpm run js-test-karma