Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/src/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ class Modal extends BaseComponent {
EventHandler.off(window, EVENT_KEY)
EventHandler.off(this._dialog, EVENT_KEY)

if (this._isShown) {
document.body.classList.remove(CLASS_NAME_OPEN)
this._resetAdjustments()
this._scrollBar.reset()
}

this._backdrop.dispose()
this._focustrap.deactivate()

Expand Down
21 changes: 21 additions & 0 deletions js/tests/unit/modal.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,27 @@ describe('Modal', () => {
expect(spyOff).toHaveBeenCalledTimes(3)
expect(spyDeactivate).toHaveBeenCalled()
})

it('should reset scrollbars when disposing a shown modal', () => {
return new Promise(resolve => {
fixtureEl.innerHTML = '<div id="exampleModal" class="modal"><div class="modal-dialog"></div></div>'

const modalEl = fixtureEl.querySelector('.modal')
const modal = new Modal(modalEl)
const spyReset = spyOn(ScrollBarHelper.prototype, 'reset').and.callThrough()

modalEl.addEventListener('shown.bs.modal', () => {
modal.dispose()

expect(spyReset).toHaveBeenCalled()
expect(document.body).not.toHaveClass('modal-open')
expect(document.body.style.overflow).toEqual('')
resolve()
})

modal.show()
})
})
})

describe('handleUpdate', () => {
Expand Down