Skip to content

bump samtools version to 1.22#24

Merged
kiarod merged 1 commit intomainfrom
kpash-update-samtools-version
Jun 4, 2025
Merged

bump samtools version to 1.22#24
kiarod merged 1 commit intomainfrom
kpash-update-samtools-version

Conversation

@kiarod
Copy link
Copy Markdown
Contributor

@kiarod kiarod commented Jun 4, 2025

Description

updating SAMtools to version 1.22

Closes #23

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Testing version:

$ docker run --rm -u $(id -u):$(id -g) ghcr.io/uclahs-cds/samtools:branch-kpash-update-samtools-version samtools --version
samtools 1.22
Using htslib 1.22
Copyright (C) 2025 Genome Research Ltd.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

ln -s /hot/ref/mitochondria_ref/mt_test_bams/tcga_test_file_normal.bam ./
docker run --workdir $(pwd) --rm --user $(id -u):$(id -g) --volume $(pwd):$(pwd) --volume /hot/ref/mitochondria_ref/mt_test_bams/:/hot/ref/mitochondria_ref/mt_test_bams/ ghcr.io/uclahs-cds/samtools:branch-kpash-update-samtools-version samtools index tcga_test_file_normal.bam

successfully creates:
tcga_test_file_normal.bam.bai

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

@kiarod kiarod requested a review from yashpatel6 June 4, 2025 17:49
Copy link
Copy Markdown
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kiarod kiarod merged commit 256f609 into main Jun 4, 2025
6 of 7 checks passed
@kiarod kiarod deleted the kpash-update-samtools-version branch June 4, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAMtools 1.22

2 participants