Skip to content

Conversation

@dwarakeshbaraneetharan
Copy link

 - Added laser_ros2_control for spectrometry laser GPIO control
 - Added killswitch_ros2_control for drive killswitch system
 - Added led_ros2_control for status LED control
 - Integrated new HWIs into athena_science.urdf.xacro
 - Added controller configurations in athena_science_controllers.yaml

Copy link
Contributor

@IshanDutta11 IshanDutta11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address some of the minor issues I have. Again, I don't expect this to be in a functioning state yet, I just want them to exist and be testable without failing instantly at a software level.

One other issue is that there are no spawners for the gpio controllers in your launch files. This means that although the hardware interfaces are loaded, the command interfaces remain unclaimed. You cannot test them in this state (I tried candump for example and nothing for your new hwis appeared).

For the laser, you can keep the GPIO controller and we can test with that, but another thing we will need for competition is a service to be exposed allowing us to turn it on and off in Henry's manual controller. I am unsure if he has made anything for the laser, so cooperate with him on this.

Keep in mind, for competition, I would prefer to make our own controller which has services for the gpio functionality instead of publishers. I think this will be a lot easier honestly. I think the only case where I don't really like that is if we want continuous color control for the LEDs and maybe even the Laser. Don't worry about that for now, we will address it in the next pull request, I would just like to hear your thoughts.

Overall, this is probably the most impressive thing I have seen on integration thus far. Very well done, some of the things I expected you to forget like one-and-done sending you got. Fix these small issues, try them on the rover, and I will approve the request.

Address team lead feedback: Laser and Killswitch now use CAN protocol instead of GPIO. LED stays GPIO. All use gpio tags and gpio_command_controller. LED and Killswitch moved from science to drive subsystem. Added simulation fallback for development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants